Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9c3ba59c authored Aug 08, 2024 by Josh Tsuji

Flag off parts of SBKVM/KVM#reset.

These calls can cause spurious shade expansion events that cause tests to fail in setup. We are trying to get rid of "reset" as a concept in the refactor, and have views/state that need to be "reset" respond to the actual state changes instead.

Bug: 278086361
Flag: com.android.systemui.keyguard_wm_state_refactor
Test: cts presubmits
Change-Id: I7152f6e49c3396f62f2720195be06d00c0e5ca20

parent 2c399676

packages/SystemUI/src/com/android/systemui/keyguard/KeyguardViewMediator.java

+6 −0

Original line number	Diff line number	Diff line
		@@ -2334,6 +2334,12 @@ public class KeyguardViewMediator implements CoreStartable, Dumpable,
		Log.e(TAG, "doKeyguard: we're still showing, but going away. Re-show the "
		+ "keyguard rather than short-circuiting and resetting.");
		} else {
		// We're removing "reset" in the refactor - "resetting" the views will happen
		// as a reaction to the root cause of the "reset" signal.
		if (KeyguardWmStateRefactor.isEnabled()) {
		return;
		}

		// It's already showing, and we're not trying to show it while the screen is
		// off. We can simply reset all of the views, but don't hide the bouncer in case
		// the user is currently interacting with it.

packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarKeyguardViewManager.java

+5 −1

Original line number	Diff line number	Diff line
		@@ -965,8 +965,12 @@ public class StatusBarKeyguardViewManager implements RemoteInputController.Callb
		if (isOccluded && !mDozing) {
		mCentralSurfaces.hideKeyguard();
		if (hideBouncerWhenShowing \|\| needsFullscreenBouncer()) {
		// We're removing "reset" in the refactor - bouncer will be hidden by the root
		// cause of the "reset" calls.
		if (!KeyguardWmStateRefactor.isEnabled()) {
		hideBouncer(false /* destroyView */);
		}
		}
		} else {
		showBouncerOrKeyguard(hideBouncerWhenShowing);
		}