Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b37843d authored by Yuchen's avatar Yuchen Committed by Yuchen Sun
Browse files

Clean up comments and build file about slice. 

Test: Existing tests passed.
Flag: EXEMPT clean up
Bug: 352442832
Change-Id: I641d50fe66dc2239eaa72d57e7e690823cf678ac
parent 509712f1

packages/SettingsLib/Spa/spa/build.gradle.kts

+0 −4
Original line number Diff line number Diff line
@@ -94,10 +94,6 @@ tasks.register<JacocoReport>("coverageReport") { 


                    // Excludes debug functions

                    "com/android/settingslib/spa/framework/compose/TimeMeasurer*",



                    // Excludes slice demo presenter & provider

                    "com/android/settingslib/spa/slice/presenter/Demo*",

                    "com/android/settingslib/spa/slice/provider/Demo*",

                )

            )

        }

packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/framework/common/SettingsEntryBuilder.kt

+0 −1
Original line number Diff line number Diff line
@@ -55,7 +55,6 @@ class SettingsEntryBuilder(private val name: String, private val owner: Settings 
            toPage = toPage,



            // attributes

            // TODO: set isEnabled & (isAllowSearch, hasSliceSupport) separately

            isAllowSearch = isEnabled && isAllowSearch,

            isSearchDataDynamic = isSearchDataDynamic,

            hasMutableStatus = hasMutableStatus,

packages/SettingsLib/Spa/spa/src/com/android/settingslib/spa/framework/common/SettingsPageProvider.kt

+2 −2
Original line number Diff line number Diff line
@@ -57,8 +57,8 @@ interface SettingsPageProvider { 
    /**

     * The API to indicate whether the page is enabled or not.

     * During SPA page migration, one can use it to enable certain pages in one release.

     * When the page is disabled, all its related functionalities, such as browsing, search,

     * slice provider, are disabled as well.

     * When the page is disabled, all its related functionalities, such as browsing and search,

     * are disabled as well.

     */

    fun isEnabled(arguments: Bundle?): Boolean = true