Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b30873b authored by rambowang's avatar rambowang Committed by Android Build Cherrypicker Worker
Browse files

Clean up flag fix_crash_on_getting_config_when_phone_is_gone 

Flag fix_crash_on_getting_config_when_phone_is_gone has been advanced to
next for a while and no regression is observed. Clean it up for now to
keep code healthy.

Bug: 319791612
Test: atest TelephonySubscriptionTrackerTest
Flag: EXEMPT flag clean up only
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:367a4c3d122bb601ac80f64346f7528a4f348812)
Merged-In: I8d02430b70c1ed432826e02bc5938c6772ff1f95
Change-Id: I8d02430b70c1ed432826e02bc5938c6772ff1f95
parent 2e1a903f

services/core/java/com/android/server/vcn/TelephonySubscriptionTracker.java

+2 −6
Original line number Original line Diff line number Diff line
@@ -44,7 +44,6 @@ import android.util.Slog; 




import com.android.internal.annotations.VisibleForTesting;

import com.android.internal.annotations.VisibleForTesting;

import com.android.internal.annotations.VisibleForTesting.Visibility;

import com.android.internal.annotations.VisibleForTesting.Visibility;

import com.android.internal.telephony.flags.Flags;

import com.android.internal.util.IndentingPrintWriter;

import com.android.internal.util.IndentingPrintWriter;

import com.android.server.vcn.util.PersistableBundleUtils.PersistableBundleWrapper;

import com.android.server.vcn.util.PersistableBundleUtils.PersistableBundleWrapper;
@@ -324,10 +323,7 @@ public class TelephonySubscriptionTracker extends BroadcastReceiver { 
        if (SubscriptionManager.isValidSubscriptionId(subId)) {

        if (SubscriptionManager.isValidSubscriptionId(subId)) {

            // Get only configs as needed to save memory.

            // Get only configs as needed to save memory.

            final PersistableBundle carrierConfig =

            final PersistableBundle carrierConfig =

                    Flags.fixCrashOnGettingConfigWhenPhoneIsGone()

                    CarrierConfigManager.getCarrierConfigSubset(mContext, subId,

                            ? CarrierConfigManager.getCarrierConfigSubset(mContext, subId,

                                    VcnManager.VCN_RELATED_CARRIER_CONFIG_KEYS)

                            : mCarrierConfigManager.getConfigForSubId(subId,

                            VcnManager.VCN_RELATED_CARRIER_CONFIG_KEYS);

                            VcnManager.VCN_RELATED_CARRIER_CONFIG_KEYS);

            if (mDeps.isConfigForIdentifiedCarrier(carrierConfig)) {

            if (mDeps.isConfigForIdentifiedCarrier(carrierConfig)) {

                mReadySubIdsBySlotId.put(slotId, subId);

                mReadySubIdsBySlotId.put(slotId, subId);

tests/vcn/java/com/android/server/vcn/TelephonySubscriptionTrackerTest.java

+0 −7
Original line number Original line Diff line number Diff line
@@ -59,7 +59,6 @@ import android.os.HandlerExecutor; 
import android.os.ParcelUuid;

import android.os.ParcelUuid;

import android.os.PersistableBundle;

import android.os.PersistableBundle;

import android.os.test.TestLooper;

import android.os.test.TestLooper;

import android.platform.test.flag.junit.SetFlagsRule;

import android.telephony.CarrierConfigManager;

import android.telephony.CarrierConfigManager;

import android.telephony.SubscriptionInfo;

import android.telephony.SubscriptionInfo;

import android.telephony.SubscriptionManager;

import android.telephony.SubscriptionManager;
@@ -73,10 +72,7 @@ import android.util.ArraySet; 
import androidx.test.filters.SmallTest;

import androidx.test.filters.SmallTest;

import androidx.test.runner.AndroidJUnit4;

import androidx.test.runner.AndroidJUnit4;





import com.android.internal.telephony.flags.Flags;



import org.junit.Before;

import org.junit.Before;

import org.junit.Rule;

import org.junit.Test;

import org.junit.Test;

import org.junit.runner.RunWith;

import org.junit.runner.RunWith;

import org.mockito.ArgumentCaptor;

import org.mockito.ArgumentCaptor;
@@ -133,8 +129,6 @@ public class TelephonySubscriptionTrackerTest { 
        TEST_SUBID_TO_CARRIER_CONFIG_MAP = Collections.unmodifiableMap(subIdToCarrierConfigMap);

        TEST_SUBID_TO_CARRIER_CONFIG_MAP = Collections.unmodifiableMap(subIdToCarrierConfigMap);

    }

    }





    @Rule public final SetFlagsRule mSetFlagsRule = new SetFlagsRule();







    @NonNull private final Context mContext;

    @NonNull private final Context mContext;

    @NonNull private final TestLooper mTestLooper;

    @NonNull private final TestLooper mTestLooper;
@@ -193,7 +187,6 @@ public class TelephonySubscriptionTrackerTest { 




    @Before

    @Before

    public void setUp() throws Exception {

    public void setUp() throws Exception {

        mSetFlagsRule.enableFlags(Flags.FLAG_FIX_CRASH_ON_GETTING_CONFIG_WHEN_PHONE_IS_GONE);

        doReturn(2).when(mTelephonyManager).getActiveModemCount();

        doReturn(2).when(mTelephonyManager).getActiveModemCount();





        mCallback = mock(TelephonySubscriptionTrackerCallback.class);

        mCallback = mock(TelephonySubscriptionTrackerCallback.class);