Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b302869 authored by Tsung-Mao Fang's avatar Tsung-Mao Fang
Browse files

Fix unknown items issue when using Switch Access 

Switch access finds the actionable item in parent view,
however, it can't find any readable text so it speaks
unknown item.

To solve this problem, we have to set focusable attribute
as false for child views, so they will be grouped in the
parent view together. Then, Switch Access can recognize
the text info with title and learn more.

Test: Play around the switch access and talkback. Both
can speak correct message in the footer.
Fix: 187241610
Bug: 209528395

Change-Id: I20a8bfa1fe1546170d254deaaff42cd4de180f5c
parent 6ba962a9

packages/SettingsLib/FooterPreference/res/layout-v31/preference_footer.xml

+0 −1
Original line number Diff line number Diff line
@@ -24,7 +24,6 @@ 
    android:paddingEnd="?android:attr/listPreferredItemPaddingEnd"

    android:background="?android:attr/selectableItemBackground"

    android:orientation="vertical"

    android:importantForAccessibility = "no"

    android:clipToPadding="false">



    <LinearLayout

packages/SettingsLib/FooterPreference/res/layout/preference_footer.xml

+0 −1
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ 
    android:paddingStart="?android:attr/listPreferredItemPaddingStart"

    android:paddingEnd="?android:attr/listPreferredItemPaddingEnd"

    android:background="?android:attr/selectableItemBackground"

    android:importantForAccessibility = "no"

    android:clipToPadding="false">



    <LinearLayout

packages/SettingsLib/FooterPreference/src/com/android/settingslib/widget/FooterPreference.java

+2 −0
Original line number Diff line number Diff line
@@ -61,6 +61,7 @@ public class FooterPreference extends Preference { 
        title.setMovementMethod(new LinkMovementMethod());

        title.setClickable(false);

        title.setLongClickable(false);

        title.setFocusable(false);

        if (!TextUtils.isEmpty(mContentDescription)) {

            title.setContentDescription(mContentDescription);

        }
@@ -79,6 +80,7 @@ public class FooterPreference extends Preference { 
            if (!TextUtils.isEmpty(mLearnMoreContentDescription)) {

                learnMore.setContentDescription(mLearnMoreContentDescription);

            }

            learnMore.setFocusable(false);

        } else {

            learnMore.setVisibility(View.GONE);

        }