Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b0a6c63 authored by Jernej Virag's avatar Jernej Virag
Browse files

Cleanup flag for notification memory dumps in bug reports 

This cleans up the released flag which adds notification memory use to
bug dump reports. This flag has been released since QPR2 and no bugs were found within the code.

(statsd logging is still flag protected with a different flag)

Bug: 254512425
Change-Id: Ie2048f3d74f38dd689663f1641410932cfe7d92d
Test: Unit tests
parent 54f6fb6d

packages/SystemUI/src/com/android/systemui/flags/Flags.kt

+0 −4
Original line number Original line Diff line number Diff line
@@ -67,10 +67,6 @@ object Flags { 
    // TODO(b/254512538): Tracking Bug

    // TODO(b/254512538): Tracking Bug

    val INSTANT_VOICE_REPLY = unreleasedFlag(111, "instant_voice_reply")

    val INSTANT_VOICE_REPLY = unreleasedFlag(111, "instant_voice_reply")





    // TODO(b/254512425): Tracking Bug

    val NOTIFICATION_MEMORY_MONITOR_ENABLED =

        releasedFlag(112, "notification_memory_monitor_enabled")



    /**

    /**

     * This flag is server-controlled and should stay as [unreleasedFlag] since we never want to

     * This flag is server-controlled and should stay as [unreleasedFlag] since we never want to

     * enable it on release builds.

     * enable it on release builds.

packages/SystemUI/src/com/android/systemui/statusbar/notification/init/NotificationsControllerImpl.kt

+1 −4
Original line number Original line Diff line number Diff line
@@ -20,7 +20,6 @@ import android.service.notification.StatusBarNotification 
import com.android.systemui.ForegroundServiceNotificationListener

import com.android.systemui.ForegroundServiceNotificationListener

import com.android.systemui.dagger.SysUISingleton

import com.android.systemui.dagger.SysUISingleton

import com.android.systemui.flags.FeatureFlags

import com.android.systemui.flags.FeatureFlags

import com.android.systemui.flags.Flags

import com.android.systemui.people.widget.PeopleSpaceWidgetManager

import com.android.systemui.people.widget.PeopleSpaceWidgetManager

import com.android.systemui.plugins.statusbar.NotificationSwipeActionHelper.SnoozeOption

import com.android.systemui.plugins.statusbar.NotificationSwipeActionHelper.SnoozeOption

import com.android.systemui.statusbar.NotificationListener

import com.android.systemui.statusbar.NotificationListener
@@ -117,10 +116,8 @@ class NotificationsControllerImpl @Inject constructor( 
        notificationLogger.setUpWithContainer(listContainer)

        notificationLogger.setUpWithContainer(listContainer)

        peopleSpaceWidgetManager.attach(notificationListener)

        peopleSpaceWidgetManager.attach(notificationListener)

        fgsNotifListener.init()

        fgsNotifListener.init()

        if (featureFlags.isEnabled(Flags.NOTIFICATION_MEMORY_MONITOR_ENABLED)) {

        memoryMonitor.get().init()

        memoryMonitor.get().init()

    }

    }

    }





    // TODO: Convert all functions below this line into listeners instead of public methods

    // TODO: Convert all functions below this line into listeners instead of public methods