Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b09c15c authored by Santos Cordon's avatar Santos Cordon Committed by Etan Cohen
Browse files

Add Sub-ID-from-phone-account converter method. 

There are several places in the code that currently attempt to parse the
sub ID directly from the phone account which is undesireable.  Before we
can change from using the subID to using an ICC ID with the phone
accounts, we need to create a conversion method so that no other
components are parsing the sub ID out of the phone account directly.

Change-Id: I74547fe0807da2fe13f3ff4422cd1d0a7a20d04c
parent 57f8f0d7

telephony/java/android/telephony/TelephonyManager.java

+19 −1
Original line number Original line Diff line number Diff line
@@ -29,6 +29,7 @@ import android.os.Bundle; 
import android.os.RemoteException;

import android.os.RemoteException;

import android.os.ServiceManager;

import android.os.ServiceManager;

import android.os.SystemProperties;

import android.os.SystemProperties;

import android.telecom.PhoneAccount;

import android.util.Log;

import android.util.Log;





import com.android.internal.telecom.ITelecomService;

import com.android.internal.telecom.ITelecomService;
@@ -4130,4 +4131,21 @@ public class TelephonyManager { 
                    ServiceState.rilRadioTechnologyToString(type));

                    ServiceState.rilRadioTechnologyToString(type));

        }

        }

    }

    }



    /**

     * Returns the subscription ID for the given phone account.

     * @hide

     */

    public int getSubIdForPhoneAccount(PhoneAccount phoneAccount) {

        int retval = SubscriptionManager.INVALID_SUBSCRIPTION_ID;

        try {

            ITelephony service = getITelephony();

            if (service != null) {

                retval = service.getSubIdForPhoneAccount(phoneAccount);

            }

        } catch (RemoteException e) {

        }



        return retval;

    }

}
 
}

telephony/java/com/android/internal/telephony/ITelephony.aidl

+6 −0
Original line number Original line Diff line number Diff line
@@ -18,6 +18,7 @@ package com.android.internal.telephony; 




import android.content.Intent;

import android.content.Intent;

import android.os.Bundle;

import android.os.Bundle;

import android.telecom.PhoneAccount;

import android.telephony.CellInfo;

import android.telephony.CellInfo;

import android.telephony.IccOpenLogicalChannelResponse;

import android.telephony.IccOpenLogicalChannelResponse;

import android.telephony.NeighboringCellInfo;

import android.telephony.NeighboringCellInfo;
@@ -879,4 +880,9 @@ interface ITelephony { 
      *   {@link android.Manifest.permission#READ_PHONE_STATE READ_PHONE_STATE}

      *   {@link android.Manifest.permission#READ_PHONE_STATE READ_PHONE_STATE}

      */

      */

    String getDeviceId();

    String getDeviceId();



    /**

     * Returns the subscription ID associated with the specified PhoneAccount.

     */

    int getSubIdForPhoneAccount(in PhoneAccount phoneAccount);

}
 
}