Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9aab6462 authored by Taran Singh's avatar Taran Singh
Browse files

Remove useHandwritingListenerForTooltype flag 

Fix: 409607490
Test: atest CtsInputMethodTestCases
Flag: EXEMPT removing android.view.inputmethod.use_handwriting_listener_for_tooltype
Change-Id: I2ec2f6340dc477888f3bd107d347fabe577cae49
parent b405bdfa

core/java/android/inputmethodservice/InputMethodService.java

+5 −8
Original line number Diff line number Diff line
@@ -1355,11 +1355,10 @@ public class InputMethodService extends AbstractInputMethodService { 
    }



    private void updateEditorToolTypeInternal(int toolType) {

        if (Flags.useHandwritingListenerForTooltype()) {

        if (mInputEditorInfo != null) {

            mInputEditorInfo.setInitialToolType(toolType);

        }

        }



        onUpdateEditorToolType(toolType);

    }
@@ -3705,10 +3704,8 @@ public class InputMethodService extends AbstractInputMethodService { 
     *         had not seen the event at all.

     */

    public boolean onKeyDown(int keyCode, KeyEvent event) {

        if (Flags.useHandwritingListenerForTooltype()) {

        // any KeyEvent keyDown should reset last toolType.

        updateEditorToolTypeInternal(MotionEvent.TOOL_TYPE_UNKNOWN);

        }



        if (keyCode == KeyEvent.KEYCODE_BACK) {

            final ExtractEditText eet = getExtractEditTextIfVisible();

core/java/android/view/inputmethod/flags.aconfig

+0 −8
Original line number Diff line number Diff line
@@ -35,14 +35,6 @@ flag { 
    bug: "279959705"

}



flag {

    name: "use_handwriting_listener_for_tooltype"

    namespace: "input_method"

    description: "Feature flag for using handwriting spy for determining pointer toolType."

    bug: "309554999"

    is_fixed_read_only: true

}



flag {

    name: "use_zero_jank_proxy"

    is_exported: true

services/core/java/com/android/server/inputmethod/InputMethodManagerService.java

+1 −5
Original line number Diff line number Diff line
@@ -3538,11 +3538,7 @@ public final class InputMethodManagerService implements IInputMethodManagerImpl. 
            ImeTracker.forLogging().onProgress(statsToken, ImeTracker.PHASE_SERVER_HAS_IME);

            userData.mCurStatsToken = null;



            if (Flags.useHandwritingListenerForTooltype()) {

            maybeReportToolType(userId);

            } else if (lastClickToolType != MotionEvent.TOOL_TYPE_UNKNOWN) {

                onUpdateEditorToolTypeLocked(lastClickToolType, userId);

            }

            mVisibilityApplier.performShowIme(windowToken, statsToken,

                    visibilityStateComputer.getShowFlagsForInputMethodServiceOnly(),

                    resultReceiver, reason, userId);