Commit 9a43192c authored May 05, 2022 by Joshua Trask

Fix logging crash in ResolverRankerService model

This was a regression introduced in ag/17913997 because
I missed that the legacy code included the ternary
`? 0 : 1` to convert from boolean to int value in this
(not-type-safe, see b/231577676) API call.

Bug: 231491021
Bug: 231577676

Test: compile/presubmit. This doesn't prove that the fix
works (we must just not have coverage, or we would've
caught the regression the first time) but it does validate
the syntax and confirm that there are no other unintended
changes (stray keystrokes...). The fix is trivial; this CL
simply restores the exact behavior pre- ag/17913997.

Change-Id: I706dee50e074da3ca40cde5b83abfd076a271959

parent 7a0ee72b

core/java/com/android/internal/app/ResolverRankerServiceResolverComparator.java

+1 −1

Original line number	Diff line number	Diff line
		@@ -589,7 +589,7 @@ class ResolverRankerServiceResolverComparator extends AbstractResolverComparator
		MetricsLogger metricsLogger = new MetricsLogger();
		LogMaker log = new LogMaker(MetricsEvent.ACTION_TARGET_SELECTED);
		log.setComponentName(mRankerServiceName);
		log.addTaggedData(MetricsEvent.FIELD_IS_CATEGORY_USED, mAnnotationsUsed);
		log.addTaggedData(MetricsEvent.FIELD_IS_CATEGORY_USED, mAnnotationsUsed ? 1 : 0);
		log.addTaggedData(MetricsEvent.FIELD_RANKED_POSITION, selectedPos);
		metricsLogger.write(log);
		}