Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a387243 authored by Qijing Yao's avatar Qijing Yao
Browse files

Ensure indicator clear transation application when drag end 

In I6f3f54de85bd564158b1cfcaf91a1955964cf575, logic was added to delay
the drag indicator removal when a drag ends.

However, in the code path where needDragIndicatorCleanup is true, the
transaction to clear the indicator was not applied. This could cause the
indicator to remain visible after the drag operation finished.

This change ensures the transaction is explicitly applied in this case,
correctly clearing the drag indicator.

Flag: com.android.window.flags.enable_window_drop_smooth_transition
Bug: 438189205
Test: manual
Change-Id: I2921c4627891a260c82fe16e41e48b18ca57c524
parent 79c374eb

libs/WindowManager/Shell/src/com/android/wm/shell/windowdecor/DesktopModeWindowDecorViewModel.java

+3 −2
Original line number Diff line number Diff line
@@ -1796,8 +1796,9 @@ public class DesktopModeWindowDecorViewModel implements WindowDecorViewModel, 
                            needDragIndicatorCleanup);

                    if (DesktopExperienceFlags.ENABLE_WINDOW_DROP_SMOOTH_TRANSITION.isTrue()) {

                        if (needDragIndicatorCleanup) {

                            mMultiDisplayDragMoveIndicatorController.onDragEnd(taskInfo.taskId,

                                    mTransactionFactory.get());

                            SurfaceControl.Transaction t = mTransactionFactory.get();

                            mMultiDisplayDragMoveIndicatorController.onDragEnd(taskInfo.taskId, t);

                            t.apply();

                        }

                    }

                    if (DesktopExperienceFlags.ENABLE_FIX_LEAKING_VISUAL_INDICATOR.isTrue()