Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 997b5b74 authored by Nataniel Borges's avatar Nataniel Borges
Browse files

Update flicker logger on platinum tests and cleanup deprecated Bp files 

To make it easier to debug issues in the future

Bug: 312755362
Test: atest WMShellFlickerTestsPip1 WMShellFlickerServiceTests
Change-Id: Ie4d04bf56d869982fe12cd3369575a791a893dd4
parent 4e42ebe6

libs/WindowManager/Shell/tests/flicker/Android.bp

+1 −8
Original line number Diff line number Diff line
@@ -52,7 +52,7 @@ java_library { 
}



java_defaults {

    name: "WMShellFlickerTestsDefaultWithoutTemplate",

    name: "WMShellFlickerTestsDefault",

    platform_apis: true,

    certificate: "platform",

    optimize: {
@@ -75,16 +75,9 @@ java_defaults { 
    ],

    data: [

        ":FlickerTestApp",

        "trace_config/*",

    ],

}



java_defaults {

    name: "WMShellFlickerTestsDefault",

    defaults: ["WMShellFlickerTestsDefaultWithoutTemplate"],

    test_config_template: "AndroidTestTemplate.xml",

}



java_library {

    name: "WMShellFlickerTestsBase",

    defaults: ["WMShellFlickerTestsDefault"],

libs/WindowManager/Shell/tests/flicker/AndroidTestTemplate.xml

deleted100644 → 0
+0 −112
Original line number Diff line number Diff line 
<?xml version="1.0" encoding="utf-8"?>

<!--

  ~ Copyright (C) 2023 The Android Open Source Project

  ~

  ~ Licensed under the Apache License, Version 2.0 (the "License");

  ~ you may not use this file except in compliance with the License.

  ~ You may obtain a copy of the License at

  ~

  ~      http://www.apache.org/licenses/LICENSE-2.0

  ~

  ~ Unless required by applicable law or agreed to in writing, software

  ~ distributed under the License is distributed on an "AS IS" BASIS,

  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

  ~ See the License for the specific language governing permissions and

  ~ limitations under the License.

  -->

<configuration description="Runs WindowManager Shell Flicker Tests {MODULE}">

    <option name="test-tag" value="FlickerTests"/>

    <!-- Needed for storing the perfetto trace files in the sdcard/test_results-->

    <option name="isolated-storage" value="false"/>



    <target_preparer class="com.android.tradefed.targetprep.DeviceSetup">

        <!-- keeps the screen on during tests -->

        <option name="screen-always-on" value="on"/>

        <!-- prevents the phone from restarting -->

        <option name="force-skip-system-props" value="true"/>

        <!-- set WM tracing verbose level to all -->

        <option name="run-command" value="cmd window tracing level all"/>

        <!-- set WM tracing to frame (avoid incomplete states) -->

        <option name="run-command" value="cmd window tracing frame"/>

        <!-- disable betterbug as it's log collection dialogues cause flakes in e2e tests -->

        <option name="run-command" value="pm disable com.google.android.internal.betterbug"/>

        <!-- ensure lock screen mode is swipe -->

        <option name="run-command" value="locksettings set-disabled false"/>

        <!-- restart launcher to activate TAPL -->

        <option name="run-command"

                value="setprop ro.test_harness 1 ; am force-stop com.google.android.apps.nexuslauncher"/>

        <!-- Increase trace size: 20mb for WM and 80mb for SF -->

        <option name="run-command" value="cmd window tracing size 20480"/>

        <option name="run-command" value="su root service call SurfaceFlinger 1029 i32 81920"/>

        <!-- b/307664397 - Ensure camera has the correct permissions and doesn't show a dialog -->

        <option name="run-command"

                value="pm grant com.google.android.GoogleCamera android.permission.ACCESS_FINE_LOCATION"/>

    </target_preparer>

    <target_preparer class="com.android.tradefed.targetprep.RunCommandTargetPreparer">

        <option name="test-user-token" value="%TEST_USER%"/>

        <option name="run-command" value="rm -rf /data/user/%TEST_USER%/files/*"/>

        <option name="run-command" value="settings put secure show_ime_with_hard_keyboard 1"/>

        <option name="run-command" value="settings put system show_touches 1"/>

        <option name="run-command" value="settings put system pointer_location 1"/>

        <option name="teardown-command"

                value="settings delete secure show_ime_with_hard_keyboard"/>

        <option name="teardown-command" value="settings delete system show_touches"/>

        <option name="teardown-command" value="settings delete system pointer_location"/>

        <option name="teardown-command"

                value="cmd overlay enable com.android.internal.systemui.navbar.gestural"/>

    </target_preparer>

    <target_preparer class="com.android.tradefed.targetprep.suite.SuiteApkInstaller">

        <option name="cleanup-apks" value="true"/>

        <option name="test-file-name" value="{MODULE}.apk"/>

        <option name="test-file-name" value="FlickerTestApp.apk"/>

    </target_preparer>

    <!-- Enable mocking GPS location by the test app -->

    <target_preparer class="com.android.tradefed.targetprep.RunCommandTargetPreparer">

        <option name="run-command"

                value="appops set com.android.wm.shell.flicker.pip.apps android:mock_location allow"/>

        <option name="teardown-command"

                value="appops set com.android.wm.shell.flicker.pip.apps android:mock_location deny"/>

    </target_preparer>



    <!-- Needed for pushing the trace config file -->

    <target_preparer class="com.android.tradefed.targetprep.RootTargetPreparer"/>

    <target_preparer class="com.android.tradefed.targetprep.PushFilePreparer">

        <option name="push-file"

                key="trace_config.textproto"

                value="/data/misc/perfetto-traces/trace_config.textproto"

        />

        <!--Install the content provider automatically when we push some file in sdcard folder.-->

        <!--Needed to avoid the installation during the test suite.-->

        <option name="push-file" key="trace_config.textproto" value="/sdcard/sample.textproto"/>

    </target_preparer>

    <test class="com.android.tradefed.testtype.AndroidJUnitTest">

        <option name="package" value="{PACKAGE}"/>

        <option name="shell-timeout" value="6600s"/>

        <option name="test-timeout" value="6000s"/>

        <option name="hidden-api-checks" value="false"/>

        <option name="device-listeners" value="android.device.collectors.PerfettoListener"/>

        <!-- PerfettoListener related arguments -->

        <option name="instrumentation-arg" key="perfetto_config_text_proto" value="true"/>

        <option name="instrumentation-arg"

                key="perfetto_config_file"

                value="trace_config.textproto"

        />

        <option name="instrumentation-arg" key="per_run" value="true"/>

    </test>

    <!-- Needed for pulling the collected trace config on to the host -->

    <metrics_collector class="com.android.tradefed.device.metric.FilePullerLogCollector">

        <option name="pull-pattern-keys" value="perfetto_file_path"/>

        <option name="directory-keys"

                value="/data/user/0/com.android.wm.shell.flicker/files"/>

        <option name="directory-keys"

                value="/data/user/0/com.android.wm.shell.flicker.bubbles/files"/>

        <option name="directory-keys"

                value="/data/user/0/com.android.wm.shell.flicker.pip/files"/>

        <option name="directory-keys"

                value="/data/user/0/com.android.wm.shell.flicker.splitscreen/files"/>

        <option name="directory-keys"

                value="/data/user/0/com.android.wm.shell.flicker.service/files"/>

        <option name="collect-on-run-ended-only" value="true"/>

        <option name="clean-up" value="true"/>

    </metrics_collector>

</configuration>

libs/WindowManager/Shell/tests/flicker/appcompat/Android.bp

+2 −0
Original line number Diff line number Diff line
@@ -36,6 +36,8 @@ android_test { 
    manifest: "AndroidManifest.xml",

    package_name: "com.android.wm.shell.flicker",

    instrumentation_target_package: "com.android.wm.shell.flicker",

    test_config_template: "AndroidTestTemplate.xml",

    srcs: [":WMShellFlickerTestsAppCompat-src"],

    static_libs: ["WMShellFlickerTestsBase"],

    data: ["trace_config/*"],

}

libs/WindowManager/Shell/tests/flicker/bubble/Android.bp

+2 −0
Original line number Diff line number Diff line
@@ -29,6 +29,8 @@ android_test { 
    manifest: "AndroidManifest.xml",

    package_name: "com.android.wm.shell.flicker.bubbles",

    instrumentation_target_package: "com.android.wm.shell.flicker.bubbles",

    test_config_template: "AndroidTestTemplate.xml",

    srcs: ["src/**/*.kt"],

    static_libs: ["WMShellFlickerTestsBase"],

    data: ["trace_config/*"],

}

libs/WindowManager/Shell/tests/flicker/pip/Android.bp

+11 −1
Original line number Diff line number Diff line
@@ -62,11 +62,13 @@ android_test { 
    manifest: "AndroidManifest.xml",

    package_name: "com.android.wm.shell.flicker.pip",

    instrumentation_target_package: "com.android.wm.shell.flicker.pip",

    test_config_template: "AndroidTestTemplate.xml",

    srcs: [

        ":WMShellFlickerTestsPip1-src",

        ":WMShellFlickerTestsPipCommon-src",

    ],

    static_libs: ["WMShellFlickerTestsBase"],

    data: ["trace_config/*"],

}



android_test {
@@ -75,11 +77,13 @@ android_test { 
    manifest: "AndroidManifest.xml",

    package_name: "com.android.wm.shell.flicker.pip",

    instrumentation_target_package: "com.android.wm.shell.flicker.pip",

    test_config_template: "AndroidTestTemplate.xml",

    srcs: [

        ":WMShellFlickerTestsPip2-src",

        ":WMShellFlickerTestsPipCommon-src",

    ],

    static_libs: ["WMShellFlickerTestsBase"],

    data: ["trace_config/*"],

}



android_test {
@@ -88,6 +92,7 @@ android_test { 
    manifest: "AndroidManifest.xml",

    package_name: "com.android.wm.shell.flicker.pip",

    instrumentation_target_package: "com.android.wm.shell.flicker.pip",

    test_config_template: "AndroidTestTemplate.xml",

    srcs: [

        ":WMShellFlickerTestsPip3-src",

        ":WMShellFlickerTestsPipCommon-src",
@@ -98,6 +103,7 @@ android_test { 
        ":WMShellFlickerTestsPipApps-src",

    ],

    static_libs: ["WMShellFlickerTestsBase"],

    data: ["trace_config/*"],

}



android_test {
@@ -106,19 +112,22 @@ android_test { 
    manifest: "AndroidManifest.xml",

    package_name: "com.android.wm.shell.flicker.pip.apps",

    instrumentation_target_package: "com.android.wm.shell.flicker.pip.apps",

    test_config_template: "AndroidTestTemplate.xml",

    srcs: [

        ":WMShellFlickerTestsPipApps-src",

        ":WMShellFlickerTestsPipCommon-src",

    ],

    static_libs: ["WMShellFlickerTestsBase"],

    data: ["trace_config/*"],

}



android_test {

    name: "WMShellFlickerTestsPipAppsCSuite",

    defaults: ["WMShellFlickerTestsDefaultWithoutTemplate"],

    defaults: ["WMShellFlickerTestsDefault"],

    additional_manifests: ["AndroidManifest.xml"],

    package_name: "com.android.wm.shell.flicker.pip.apps",

    instrumentation_target_package: "com.android.wm.shell.flicker.pip.apps",

    test_config_template: "AndroidTestTemplate.xml",

    srcs: [

        ":WMShellFlickerTestsPipApps-src",

        ":WMShellFlickerTestsPipCommon-src",
@@ -128,6 +137,7 @@ android_test { 
        "device-tests",

        "csuite",

    ],

    data: ["trace_config/*"],

}



csuite_test {