Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 98ebd7e1 authored by Alan Chen's avatar Alan Chen
Browse files

Remove legacy SharedPreference migration 

Phonebook and Message bluetooth permissions used to be in
Settings app in Android 4 and removed in Android 5.
These methods are legacy code to support the transition,
and the SharedPreferences are not written to anymore.

Bug: 402789702
Test: pair bt device on a locked automotive build, reboot
and observe no crash
Flag: EXEMPT bugfix only

Change-Id: I1018e7c067c454cd07bbab9b80814bf21415de26
parent b59a4c08

packages/SettingsLib/src/com/android/settingslib/bluetooth/CachedBluetoothDevice.java

+0 −52
Original line number Diff line number Diff line
@@ -29,7 +29,6 @@ import android.bluetooth.BluetoothLeBroadcastReceiveState; 
import android.bluetooth.BluetoothProfile;

import android.bluetooth.BluetoothUuid;

import android.content.Context;

import android.content.SharedPreferences;

import android.content.res.Resources;

import android.graphics.drawable.BitmapDrawable;

import android.graphics.drawable.Drawable;
@@ -678,9 +677,6 @@ public class CachedBluetoothDevice implements Comparable<CachedBluetoothDevice> 
    void fillData() {

        updateProfiles();

        fetchActiveDevices();

        migratePhonebookPermissionChoice();

        migrateMessagePermissionChoice();



        dispatchAttributesChanged();

    }
@@ -1347,54 +1343,6 @@ public class CachedBluetoothDevice implements Comparable<CachedBluetoothDevice> 
        void onDeviceAttributesChanged();

    }



    // Migrates data from old data store (in Settings app's shared preferences) to new (in Bluetooth

    // app's shared preferences).

    private void migratePhonebookPermissionChoice() {

        SharedPreferences preferences = mContext.getSharedPreferences(

                "bluetooth_phonebook_permission", Context.MODE_PRIVATE);

        if (!preferences.contains(mDevice.getAddress())) {

            return;

        }



        if (mDevice.getPhonebookAccessPermission() == BluetoothDevice.ACCESS_UNKNOWN) {

            int oldPermission =

                    preferences.getInt(mDevice.getAddress(), BluetoothDevice.ACCESS_UNKNOWN);

            if (oldPermission == BluetoothDevice.ACCESS_ALLOWED) {

                mDevice.setPhonebookAccessPermission(BluetoothDevice.ACCESS_ALLOWED);

            } else if (oldPermission == BluetoothDevice.ACCESS_REJECTED) {

                mDevice.setPhonebookAccessPermission(BluetoothDevice.ACCESS_REJECTED);

            }

        }



        SharedPreferences.Editor editor = preferences.edit();

        editor.remove(mDevice.getAddress());

        editor.commit();

    }



    // Migrates data from old data store (in Settings app's shared preferences) to new (in Bluetooth

    // app's shared preferences).

    private void migrateMessagePermissionChoice() {

        SharedPreferences preferences = mContext.getSharedPreferences(

                "bluetooth_message_permission", Context.MODE_PRIVATE);

        if (!preferences.contains(mDevice.getAddress())) {

            return;

        }



        if (mDevice.getMessageAccessPermission() == BluetoothDevice.ACCESS_UNKNOWN) {

            int oldPermission =

                    preferences.getInt(mDevice.getAddress(), BluetoothDevice.ACCESS_UNKNOWN);

            if (oldPermission == BluetoothDevice.ACCESS_ALLOWED) {

                mDevice.setMessageAccessPermission(BluetoothDevice.ACCESS_ALLOWED);

            } else if (oldPermission == BluetoothDevice.ACCESS_REJECTED) {

                mDevice.setMessageAccessPermission(BluetoothDevice.ACCESS_REJECTED);

            }

        }



        SharedPreferences.Editor editor = preferences.edit();

        editor.remove(mDevice.getAddress());

        editor.commit();

    }



    private void processPhonebookAccess() {

        if (mDevice.getBondState() != BluetoothDevice.BOND_BONDED) return;