Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9852897b authored by Felipe Leme's avatar Felipe Leme
Browse files

New Autofill API: SaveRequest.getDatasetIds() 

Test: modified some existing CTS tests to use it
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 64843801

Change-Id: I95fe7766f19e5a9eea9d7138636a15cc832c704c
parent 9eb7a69e

api/current.txt

+1 −0
Original line number Diff line number Diff line
@@ -37193,6 +37193,7 @@ package android.service.autofill { 
  public final class SaveRequest implements android.os.Parcelable {

    method public int describeContents();

    method public android.os.Bundle getClientState();

    method public java.util.List<java.lang.String> getDatasetIds();

    method public java.util.List<android.service.autofill.FillContext> getFillContexts();

    method public void writeToParcel(android.os.Parcel, int);

    field public static final android.os.Parcelable.Creator<android.service.autofill.SaveRequest> CREATOR;

api/system-current.txt

+1 −0
Original line number Diff line number Diff line
@@ -40284,6 +40284,7 @@ package android.service.autofill { 
  public final class SaveRequest implements android.os.Parcelable {

    method public int describeContents();

    method public android.os.Bundle getClientState();

    method public java.util.List<java.lang.String> getDatasetIds();

    method public java.util.List<android.service.autofill.FillContext> getFillContexts();

    method public void writeToParcel(android.os.Parcel, int);

    field public static final android.os.Parcelable.Creator<android.service.autofill.SaveRequest> CREATOR;

api/test-current.txt

+1 −0
Original line number Diff line number Diff line
@@ -37395,6 +37395,7 @@ package android.service.autofill { 
  public final class SaveRequest implements android.os.Parcelable {

    method public int describeContents();

    method public android.os.Bundle getClientState();

    method public java.util.List<java.lang.String> getDatasetIds();

    method public java.util.List<android.service.autofill.FillContext> getFillContexts();

    method public void writeToParcel(android.os.Parcel, int);

    field public static final android.os.Parcelable.Creator<android.service.autofill.SaveRequest> CREATOR;

core/java/android/os/Parcel.java

+0 −3
Original line number Diff line number Diff line
@@ -2555,9 +2555,6 @@ public final class Parcel { 
     * Read into the given List items String objects that were written with

     * {@link #writeStringList} at the current dataPosition().

     *

     * @return A newly created ArrayList containing strings with the same data

     *         as those that were previously written.

     *

     * @see #writeStringList

     */

    public final void readStringList(List<String> list) {

core/java/android/service/autofill/Dataset.java

+13 −6
Original line number Diff line number Diff line
@@ -198,15 +198,22 @@ public final class Dataset implements Parcelable { 
        }



        /**

         * Sets the id for the dataset so its usage history can be retrieved later.

         * Sets the id for the dataset so its usage can be tracked.

         *

         * <p>The id of the last selected dataset can be read from

         * {@link AutofillService#getFillEventHistory()}. If the id is not set it will not be clear

         * if a dataset was selected as {@link AutofillService#getFillEventHistory()} uses

         * {@code null} to indicate that no dataset was selected.

         * <p>Dataset usage can be tracked for 2 purposes:

         *

         * <ul>

         *   <li>For statistical purposes, the service can call

         * {@link AutofillService#getFillEventHistory()} when handling {@link

         * AutofillService#onFillRequest(FillRequest, android.os.CancellationSignal, FillCallback)}

         * calls.

         *   <li>For normal autofill workflow, the service can call

         *   {@link SaveRequest#getDatasetIds()} when handling

         *   {@link AutofillService#onSaveRequest(SaveRequest, SaveCallback)} calls.

         * </ul>

         *

         * @param id id for this dataset or {@code null} to unset.



         *

         * @return This builder.

         */

        public @NonNull Builder setId(@Nullable String id) {