Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 97d062ea authored by Vladimir Komsiyski's avatar Vladimir Komsiyski
Browse files

Allow the system user to access public displays 

On HSUM devices some activity launches as the system user on public
secondary displays fail (VirtualDeviceHomeTest) because that user is
not considered "visible" by UserVisibilityMediator.

This is already taken into account in DisplayContent#hasAccess but
not in ActivityTaskSupervisor#isCallerAllowedToLaunchOnDisplay.
A similar check is done in Display#hasAccess and both of the existing
methods allow the access for the system user.

This CL is simply making the logic consistent and valdiating the
HSUM support for these activity launches.

Fix: 376008387
Test: atest VirtualDeviceHomeTest
Flag: EXEMPT trvivial bugfix
Change-Id: I708e33c0917a3a589528de2cfaf7edb2aed8c547
parent 57724986

services/core/java/com/android/server/wm/ActivityTaskSupervisor.java

+2 −1
Original line number Diff line number Diff line
@@ -1268,7 +1268,8 @@ public class ActivityTaskSupervisor implements RecentTasks.Callbacks { 
            // Checks if the caller can be shown in the given public display.

            int userId = UserHandle.getUserId(callingUid);

            int displayId = display.getDisplayId();

            boolean allowed = mWindowManager.mUmInternal.isUserVisible(userId, displayId);

            boolean allowed = userId == UserHandle.USER_SYSTEM

                    || mWindowManager.mUmInternal.isUserVisible(userId, displayId);

            ProtoLog.d(WM_DEBUG_TASKS,

                    "Launch on display check: %s launch for userId=%d on displayId=%d",

                    (allowed ? "allow" : "disallow"), userId, displayId);