Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9753dd74 authored by Tim Murray's avatar Tim Murray Committed by Tyler Freeman
Browse files

FontScaleConverterFactoryTest: 15x perf increase 

Most of the time is spent in object allocation for the assert. Check
to see if the calculation would fail, and only actually run the assert
if it fails.

Test: atest FontScaleConverterFactoryTest#allFeasibleScalesAndConversionsDoNotCrash
Bug: 270054472
Change-Id: Id879c5442869766ec89e5e8173152d2db6631fd4
parent f19df858

core/tests/coretests/src/android/content/res/FontScaleConverterFactoryTest.kt

+7 −3
Original line number Diff line number Diff line
@@ -90,9 +90,13 @@ class FontScaleConverterFactoryTest { 
            }

            .forEach { (table, sp) ->

                try {

                    // Truth is slow because it creates a bunch of

                    // objects. Don't use it unless we need to.

                    if (!table.convertSpToDp(sp).isFinite()) {

                        assertWithMessage("convertSpToDp(%s) on table: %s", sp, table)

                            .that(table.convertSpToDp(sp))

                            .isFinite()

                    }

                } catch (e: Exception) {

                    throw AssertionError("Exception during convertSpToDp($sp) on table: $table", e)

                }