Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96d7245c authored by Alex Klyubin's avatar Alex Klyubin
Browse files

Cleanup Binder token resetting. 

This is a follow-up to 7cbcfd4f where
during the review it was pointed out that the code could be
streamlined.

Bug: 18088752
Change-Id: Iecb9fdbc31a0f3cdcb94ddb1b3e7e12a0543a231
parent 614b39f3

keystore/java/android/security/keystore/AndroidKeyStoreCipherSpiBase.java

+1 −2
Original line number Diff line number Diff line
@@ -162,7 +162,6 @@ abstract class AndroidKeyStoreCipherSpiBase extends CipherSpi implements KeyStor 
    protected void resetAll() {

        IBinder operationToken = mOperationToken;

        if (operationToken != null) {

            mOperationToken = null;

            mKeyStore.abort(operationToken);

        }

        mEncrypting = false;
@@ -186,9 +185,9 @@ abstract class AndroidKeyStoreCipherSpiBase extends CipherSpi implements KeyStor 
    protected void resetWhilePreservingInitState() {

        IBinder operationToken = mOperationToken;

        if (operationToken != null) {

            mOperationToken = null;

            mKeyStore.abort(operationToken);

        }

        mOperationToken = null;

        mOperationHandle = 0;

        mMainDataStreamer = null;

        mCachedException = null;

keystore/java/android/security/keystore/AndroidKeyStoreHmacSpi.java

+2 −2
Original line number Diff line number Diff line
@@ -128,9 +128,9 @@ public abstract class AndroidKeyStoreHmacSpi extends MacSpi implements KeyStoreC 
        mKey = null;

        IBinder operationToken = mOperationToken;

        if (operationToken != null) {

            mOperationToken = null;

            mKeyStore.abort(operationToken);

        }

        mOperationToken = null;

        mOperationHandle = 0;

        mChunkedStreamer = null;

    }
@@ -138,9 +138,9 @@ public abstract class AndroidKeyStoreHmacSpi extends MacSpi implements KeyStoreC 
    private void resetWhilePreservingInitState() {

        IBinder operationToken = mOperationToken;

        if (operationToken != null) {

            mOperationToken = null;

            mKeyStore.abort(operationToken);

        }

        mOperationToken = null;

        mOperationHandle = 0;

        mChunkedStreamer = null;

    }