Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96afb6f0 authored by Jim Miller's avatar Jim Miller
Browse files

Fix deadlock caused by synchronous setOccluded() method in keyguard 

This fixes a deadlock where WindowManagerService can call into
KeyguardService.setOccluded() while holding a lock. As soon as keyguard
receives the call, it immediately needs to check permission and calls
back into the system service which is waiting for the lock to be
released. Boom!

The fix does a quick check of the calling UID and allows the call
if coming from the System UID, thus bypassing the need for a
binder call to checkPermission().

Fixes bug 18362246

Change-Id: Iab4be8a885f330fb2a62ee7e3579966e1447f8b0
parent bba231d7

packages/SystemUI/src/com/android/systemui/keyguard/KeyguardService.java

+5 −0
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ import android.os.Binder; 
import android.os.Bundle;

import android.os.Debug;

import android.os.IBinder;

import android.os.Process;

import android.util.Log;

import android.view.MotionEvent;
@@ -52,6 +53,10 @@ public class KeyguardService extends Service { 
    }



    void checkPermission() {

        // Avoid deadlock by avoiding calling back into the system process.

        if (Binder.getCallingUid() == Process.SYSTEM_UID) return;



        // Otherwise,explicitly check for caller permission ...

        if (getBaseContext().checkCallingOrSelfPermission(PERMISSION) != PERMISSION_GRANTED) {

            Log.w(TAG, "Caller needs permission '" + PERMISSION + "' to call " + Debug.getCaller());

            throw new SecurityException("Access denied to process: " + Binder.getCallingPid()