Commit 9680f394 authored Mar 22, 2021 by Hai Zhang

Fix revokePermissionsNoLongerImplicitLocked() for shared UIDs.

The method should have considered all the packages in a shared UID, but
it only took the package passed in into consideration, and would
incorrectly revoke permissions that's implicit from another package in
the same UID. The proper way is to always consider permission state by
UID, but as a simple fix, considering each package only by their
requested permissions works the same. The revocation of permissions no
longer requested is handled elsewhere and involves removing the entire
permission state, so it's also safe to only consider requested
permissions here.

Bug: 183304624
Test: manual
Change-Id: I26b4bd7007cfed662c56628723e4be2718093880

parent 1fe4cb3e

services/core/java/com/android/server/pm/permission/PermissionManagerService.java

+2 −1

Original line number	Diff line number	Diff line
		@@ -2937,7 +2937,8 @@ public class PermissionManagerService extends IPermissionManager.Stub {
		>= Build.VERSION_CODES.M;

		for (String permission : ps.getGrantedPermissions()) {
		if (!pkg.getImplicitPermissions().contains(permission)) {
		if (pkg.getRequestedPermissions().contains(permission)
		&& !pkg.getImplicitPermissions().contains(permission)) {
		Permission bp = mRegistry.getPermission(permission);
		if (bp != null && bp.isRuntime()) {
		int flags = ps.getPermissionFlags(permission);