Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 961c7efb authored by Nikita Ioffe's avatar Nikita Ioffe
Browse files

Improve exception in validate{Apex,Apk}InstallLocked 

* Mention session id;
* Mention stageDir;

This won't help with b/152793689, but should help debugging similar
issues in the future.

Test: builds
Bug: 152793689
Change-Id: Ie6ac43764ae082a4805941fafb07bd841e422630
parent c0a89245

services/core/java/com/android/server/pm/PackageInstallerSession.java

+6 −2
Original line number Diff line number Diff line
@@ -1830,7 +1830,9 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub { 
            throws PackageManagerException {

        final List<File> addedFiles = getAddedApksLocked();

        if (addedFiles.isEmpty()) {

            throw new PackageManagerException(INSTALL_FAILED_INVALID_APK, "No packages staged");

            throw new PackageManagerException(INSTALL_FAILED_INVALID_APK,

                    String.format("Session: %d. No packages staged in %s", sessionId,

                          stageDir.getAbsolutePath()));

        }



        if (ArrayUtils.size(addedFiles) > 1) {
@@ -1921,7 +1923,9 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub { 


        final List<File> addedFiles = getAddedApksLocked();

        if (addedFiles.isEmpty() && removeSplitList.size() == 0) {

            throw new PackageManagerException(INSTALL_FAILED_INVALID_APK, "No packages staged");

            throw new PackageManagerException(INSTALL_FAILED_INVALID_APK,

                    String.format("Session: %d. No packages staged in %s", sessionId,

                          stageDir.getAbsolutePath()));

        }



        // Verify that all staged packages are internally consistent