Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 952d8b0a authored by Jayant Chowdhary's avatar Jayant Chowdhary
Browse files

camera2: reduce logspam from cameraIdHasConcurrentStreams. 



Physical camera ids aren't included in concurrent camera combinations.
The logs aren't real errors. Make them debug logs.

Bug: 184194887

Test: atest LogicalCameraTest#testBasicPhysicalStreaming doesn't show
      unecessary logs while calling getCameraCharacteristics for
      physical camera ids.

Change-Id: I4f6e9030f23c31e0dc796882e6e82964d5a80668
Signed-off-by: default avatarJayant Chowdhary <jchowdhary@google.com>
parent 6c9640f8

core/java/android/hardware/camera2/CameraManager.java

+5 −1
Original line number Diff line number Diff line
@@ -1500,7 +1500,11 @@ public final class CameraManager { 
        */

        public boolean cameraIdHasConcurrentStreamsLocked(String cameraId) {

            if (!mDeviceStatus.containsKey(cameraId)) {

                Log.e(TAG, "cameraIdHasConcurrentStreamsLocked called on non existing camera id");

                // physical camera ids aren't advertised in concurrent camera id combinations.

                if (DEBUG) {

                    Log.v(TAG, " physical camera id " + cameraId + " is hidden." +

                            " Available logical camera ids : " + mDeviceStatus.toString());

                }

                return false;

            }

            for (Set<String> comb : mConcurrentCameraIdCombinations) {