Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9521453a authored by Jiaming Cheng's avatar Jiaming Cheng
Browse files

Fixed progress bar display issue in Internet details view 

This is the same fix as in the legacy dialog: ag/31876688
- Turn off progress bar when Wi-Fi is off

Bug: 393162738
Flag: com.android.systemui.qs_tile_detailed_view
Change-Id: Ia4338b5fc4398f096a26bf2e8e86298d2d5c6f15
parent 643e01bf

packages/SystemUI/src/com/android/systemui/qs/tiles/dialog/InternetDetailsContentManager.kt

+4 −0
Original line number Diff line number Diff line
@@ -351,6 +351,10 @@ constructor( 
        title = getTitleText()

        subTitle = getSubtitleText()



        if (!internetContent.isWifiEnabled) {

            setProgressBarVisible(false)

        }



        airplaneModeButton.visibility =

            if (internetContent.isAirplaneModeEnabled) View.VISIBLE else View.GONE

packages/SystemUI/tests/src/com/android/systemui/qs/tiles/dialog/InternetDetailsContentManagerTest.kt

+15 −0
Original line number Diff line number Diff line
@@ -797,6 +797,21 @@ class InternetDetailsContentManagerTest : SysuiTestCase() { 
        }

    }



    @Test

    fun turnOffProgressBarWhenWifiDisabled() {

        whenever(internetDetailsContentController.isWifiEnabled).thenReturn(false)

        internetDetailsContentManager.isProgressBarVisible = true



        internetDetailsContentManager.updateContent(false)



        bgExecutor.runAllReady()

        internetDetailsContentManager.internetContentData.observe(

            internetDetailsContentManager.lifecycleOwner!!

        ) {

            assertThat(internetDetailsContentManager.isProgressBarVisible).isFalse()

        }

    }



    companion object {

        private const val TITLE = "Internet"

        private const val MOBILE_NETWORK_TITLE = "Mobile Title"