Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 94ba4017 authored by Svet Ganov's avatar Svet Ganov
Browse files

Use proper package name and UID when checking write settings access 

bug:26941229

Change-Id: I338fe6dd7c1b97f273909672cdd7d4fa207185ce
parent 1bb269d8

core/java/android/provider/Settings.java

+4 −6
Original line number Diff line number Diff line
@@ -1569,9 +1569,8 @@ public final class Settings { 
     * @return true if the calling app can draw on top of other apps, false otherwise.

     */

    public static boolean canDrawOverlays(Context context) {

        int uid = Binder.getCallingUid();

        return Settings.isCallingPackageAllowedToDrawOverlays(context, uid, Settings

                .getPackageNameForUid(context, uid), false);

        return Settings.isCallingPackageAllowedToDrawOverlays(context, Process.myUid(),

                context.getOpPackageName(), false);

    }



    /**
@@ -3885,9 +3884,8 @@ public final class Settings { 
         * @return true if the calling app can write to system settings, false otherwise

         */

        public static boolean canWrite(Context context) {

            int uid = Binder.getCallingUid();

            return isCallingPackageAllowedToWriteSettings(context, uid, getPackageNameForUid(

                    context, uid), false);

            return isCallingPackageAllowedToWriteSettings(context, Process.myUid(),

                    context.getOpPackageName(), false);

        }

    }