Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9464e295 authored by Kevin Han's avatar Kevin Han
Browse files

Add logging to NotifBindPipeline

Add logging in the case where we return early because the row is not yet
set.

Bug: 112656837
Test: manual
Change-Id: Ic0a9b58c2cf1ef8e1dc1496ad98e7337e0eb1500
parent 235f1db1
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -154,12 +154,14 @@ public final class NotifBindPipeline {
     * the real work once rather than repeatedly start and cancel it.
     */
    private void requestPipelineRun(NotificationEntry entry) {
        mLogger.logRequestPipelineRun(entry.getKey());

        final BindEntry bindEntry = getBindEntry(entry);
        if (bindEntry.row == null) {
            // Row is not managed yet but may be soon. Stop for now.
            mLogger.logRequestPipelineRowNotSet(entry.getKey());
            return;
        }
        mLogger.logRequestPipelineRun(entry.getKey());

        // Abort any existing pipeline run
        mStage.abortStage(entry, bindEntry.row);
+9 −0
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ package com.android.systemui.statusbar.notification.row

import com.android.systemui.log.LogBuffer
import com.android.systemui.log.LogLevel.INFO
import com.android.systemui.log.LogLevel.WARNING
import com.android.systemui.log.dagger.NotificationLog
import javax.inject.Inject

@@ -48,6 +49,14 @@ class NotifBindPipelineLogger @Inject constructor(
        })
    }

    fun logRequestPipelineRowNotSet(notifKey: String) {
        buffer.log(TAG, WARNING, {
            str1 = notifKey
        }, {
            "Row is not set so pipeline will not run. notif = $str1"
        })
    }

    fun logStartPipeline(notifKey: String) {
        buffer.log(TAG, INFO, {
            str1 = notifKey