Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9458a6a6 authored Oct 23, 2023 by Marvin Ramin

Remove virtual_devices more_logs flag

Flag has been rolled out to next. Testing has concluded. The flag + the
flagged code can be removed.

Test: N/A
Bug: 297220822
Change-Id: I0cb0782cccd18d6d858b5971115ac53f4094ebed

parent 116ad772

core/java/android/companion/virtual/VirtualDeviceManager.java

+0 −3

Original line number	Diff line number	Diff line
		@@ -184,9 +184,6 @@ public final class VirtualDeviceManager {
		int associationId,
		@NonNull VirtualDeviceParams params) {
		Objects.requireNonNull(params, "params must not be null");
		if (Flags.moreLogs()) {
		Log.i(TAG, "Creating VirtualDevice");
		}
		try {
		return new VirtualDevice(mService, mContext, associationId, params);
		} catch (RemoteException e) {

core/java/android/companion/virtual/flags.aconfig

+0 −7

Original line number	Diff line number	Diff line
		package: "android.companion.virtual.flags"

		flag {
		name: "more_logs"
		namespace: "virtual_devices"
		description: "More logs to test flags with"
		bug: "291725823"
		}

		flag {
		name: "enable_native_vdm"
		namespace: "virtual_devices"

services/companion/java/com/android/server/companion/virtual/VirtualDeviceManagerService.java

+0 −8

Original line number	Diff line number	Diff line
		@@ -355,14 +355,6 @@ public class VirtualDeviceManagerService extends SystemService {
		@NonNull IVirtualDeviceSoundEffectListener soundEffectListener) {
		createVirtualDevice_enforcePermission();
		attributionSource.enforceCallingUid();
		final long identity = Binder.clearCallingIdentity();
		try {
		if (Flags.moreLogs()) {
		Slog.i(TAG, "Creating VirtualDevice");
		}
		} finally {
		Binder.restoreCallingIdentity(identity);
		}

		final int callingUid = getCallingUid();
		final String packageName = attributionSource.getPackageName();