Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 93c7b643 authored by Jean Chalard's avatar Jean Chalard Committed by Gerrit Code Review
Browse files

Merge "Document limitations of the VpnService setHttpProxy API" into main

parents fd589b47 f705f5a1

core/java/android/net/VpnService.java

+9 −2
Original line number Diff line number Diff line
@@ -537,8 +537,15 @@ public class VpnService extends Service { 
        }



        /**

         * Sets an HTTP proxy for the VPN network. This proxy is only a recommendation

         * and it is possible that some apps will ignore it. PAC proxies are not supported.

         * Sets an HTTP proxy for the VPN network.

         * <p class="note">This proxy is only a recommendation and it is possible that some apps

         * will ignore it.

         * <p class="note">PAC proxies are not supported over VPNs.

         * <p class="note">Apps that do use the proxy cannot distinguish between routes handled

         * and not handled by the VPN and will try to access HTTP resources over the proxy

         * regardless of the destination. In practice this means using a proxy with a split

         * tunnel generally won't work as expected, because HTTP accesses on routes not handled by

         * the VPN will not reach as the proxy won't be available outside of the VPN network.

         */

        @NonNull

        public Builder setHttpProxy(@NonNull ProxyInfo proxyInfo) {