Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 936c040e authored by Jae Seo's avatar Jae Seo
Browse files

TIF: Make all the parameters for UNRATED null 

UNRATED is equivalent to Java null in its meaning and usage, thus it is
not appropriate to use non-trivial strings such as "com.android.tv" and
"UNRATED" to create this constant. Replaced them with the string "null",
which is commonly used in other parts of Android and also modified the
documentation to clarify its usage.

Bug: 19102311
Change-Id: I28ac8da3584eb2cc6dfd7284e2b88873fd4e9d13
parent 5b402fd8

media/java/android/media/tv/TvContentRating.java

+8 −3
Original line number Original line Diff line number Diff line
@@ -783,10 +783,15 @@ public final class TvContentRating { 
    private final int mHashCode;

    private final int mHashCode;





    /**

    /**

     * Rating constant denoting unrated content.

     * Rating constant denoting unrated content. Used to handle the case where the content rating

     * information is missing.

     *

     * <p>TV input services can call {@link TvInputManager#isRatingBlocked} with this constant to

     * determine whether they should block unrated content. The subsequent call to

     * {@link TvInputService.Session#notifyContentBlocked} with the same constant notifies

     * applications that the current program content is blocked by parental controls.

     */

     */

    public static final TvContentRating UNRATED = new TvContentRating("com.android.tv", "",

    public static final TvContentRating UNRATED = new TvContentRating("null", "null", "null", null);

            "UNRATED", null);





    /**

    /**

     * Creates a {@code TvContentRating} object with predefined content rating strings.

     * Creates a {@code TvContentRating} object with predefined content rating strings.

media/java/android/media/tv/TvInputManager.java

+1 −1
Original line number Original line Diff line number Diff line
@@ -1035,7 +1035,7 @@ public final class TvInputManager { 
    /**

    /**

     * Checks whether a given TV content rating is blocked by the user.

     * Checks whether a given TV content rating is blocked by the user.

     *

     *

     * @param rating The TV content rating to check.

     * @param rating The TV content rating to check. Can be {@link TvContentRating#UNRATED}.

     * @return {@code true} if the given TV content rating is blocked, {@code false} otherwise.

     * @return {@code true} if the given TV content rating is blocked, {@code false} otherwise.

     */

     */

    public boolean isRatingBlocked(@NonNull TvContentRating rating) {

    public boolean isRatingBlocked(@NonNull TvContentRating rating) {

media/java/android/media/tv/TvInputService.java

+8 −6
Original line number Original line Diff line number Diff line
@@ -528,11 +528,12 @@ public abstract class TvInputService extends Service { 
         * TvInputManager.isParentalControlsEnabled()} returns {@code true}). Whether the TV input

         * TvInputManager.isParentalControlsEnabled()} returns {@code true}). Whether the TV input

         * service should block the content or not is determined by invoking

         * service should block the content or not is determined by invoking

         * {@link TvInputManager#isRatingBlocked TvInputManager.isRatingBlocked(TvContentRating)}

         * {@link TvInputManager#isRatingBlocked TvInputManager.isRatingBlocked(TvContentRating)}

         * with the content rating for the current program. Then the {@link TvInputManager} makes a

         * with the content rating for the current program or {@link TvContentRating#UNRATED} in

         * judgment based on the user blocked ratings stored in the secure settings and returns the

         * case the rating information is missing. Then the {@link TvInputManager} makes a judgment

         * result. If the rating in question turns out to be blocked, the TV input service must

         * based on the user blocked ratings stored in the secure settings and returns the result.

         * immediately block the content and call this method with the content rating of the current

         * If the rating in question turns out to be blocked, the TV input service must immediately

         * program to prompt the PIN verification screen.

         * block the content and call this method with the content rating of the current program to

         * prompt the PIN verification screen.

         *

         *

         * <p>Each TV input service also needs to continuously listen to any changes made to the

         * <p>Each TV input service also needs to continuously listen to any changes made to the

         * parental controls settings by registering a broadcast receiver to receive

         * parental controls settings by registering a broadcast receiver to receive
@@ -540,7 +541,8 @@ public abstract class TvInputService extends Service { 
         * {@link TvInputManager#ACTION_PARENTAL_CONTROLS_ENABLED_CHANGED} and immediately

         * {@link TvInputManager#ACTION_PARENTAL_CONTROLS_ENABLED_CHANGED} and immediately

         * reevaluate the current program with the new parental controls settings.

         * reevaluate the current program with the new parental controls settings.

         *

         *

         * @param rating The content rating for the current TV program.

         * @param rating The content rating for the current TV program. Can be

         *            {@link TvContentRating#UNRATED}.

         * @see #notifyContentAllowed

         * @see #notifyContentAllowed

         * @see TvInputManager

         * @see TvInputManager

         */

         */