Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 934c64ca authored by arangelov's avatar arangelov Committed by Antoan Angelov
Browse files

Show a line below the tabs in tabbed view to align with UX mocks. 

When tabs are disabled, the lines are still shown to be consistent
with Q.

Fixes: 149574743
Test: manual

Change-Id: I2307230e86da72a3f7c7d90d1454859490def679
parent 1c2e160f

core/java/com/android/internal/app/ChooserActivity.java

+1 −1
Original line number Original line Diff line number Diff line
@@ -3095,7 +3095,7 @@ public class ChooserActivity extends ResolverActivity implements 
            final ViewGroup viewGroup = (ViewGroup) holder.itemView;

            final ViewGroup viewGroup = (ViewGroup) holder.itemView;

            int start = getListPosition(position);

            int start = getListPosition(position);

            int startType = getRowType(start);

            int startType = getRowType(start);

            if (viewGroup.getForeground() == null) {

            if (viewGroup.getForeground() == null && position > 0) {

                viewGroup.setForeground(

                viewGroup.setForeground(

                        getResources().getDrawable(R.drawable.chooser_row_layer_list, null));

                        getResources().getDrawable(R.drawable.chooser_row_layer_list, null));

            }

            }

core/java/com/android/internal/app/ResolverActivity.java

+1 −0
Original line number Original line Diff line number Diff line
@@ -1535,6 +1535,7 @@ public class ResolverActivity extends Activity implements 
        viewPager.setVisibility(View.VISIBLE);

        viewPager.setVisibility(View.VISIBLE);

        tabHost.setCurrentTab(mMultiProfilePagerAdapter.getCurrentPage());

        tabHost.setCurrentTab(mMultiProfilePagerAdapter.getCurrentPage());

        mMultiProfilePagerAdapter.setOnProfileSelectedListener(tabHost::setCurrentTab);

        mMultiProfilePagerAdapter.setOnProfileSelectedListener(tabHost::setCurrentTab);

        findViewById(R.id.resolver_tab_divider).setVisibility(View.VISIBLE);

    }

    }





    private void resetTabsHeaderStyle(TabWidget tabWidget) {

    private void resetTabsHeaderStyle(TabWidget tabWidget) {

core/res/res/layout/chooser_grid.xml

+8 −0
Original line number Original line Diff line number Diff line
@@ -78,6 +78,14 @@ 
                android:layout_height="wrap_content"

                android:layout_height="wrap_content"

                android:visibility="gone">

                android:visibility="gone">

            </TabWidget>

            </TabWidget>

            <View

                android:id="@+id/resolver_tab_divider"

                android:visibility="gone"

                android:layout_alwaysShow="true"

                android:layout_width="match_parent"

                android:layout_height="1dp"

                android:background="?attr/colorBackgroundFloating"

                android:foreground="?attr/dividerVertical" />

            <FrameLayout

            <FrameLayout

                android:id="@android:id/tabcontent"

                android:id="@android:id/tabcontent"

                android:layout_width="match_parent"

                android:layout_width="match_parent"

core/res/res/layout/resolver_list.xml

+8 −4
Original line number Original line Diff line number Diff line
@@ -94,6 +94,13 @@ 
                android:layout_height="wrap_content"

                android:layout_height="wrap_content"

                android:visibility="gone">

                android:visibility="gone">

            </TabWidget>

            </TabWidget>

            <View

                android:id="@+id/resolver_tab_divider"

                android:visibility="gone"

                android:layout_width="match_parent"

                android:layout_height="1dp"

                android:background="?attr/colorBackgroundFloating"

                android:foreground="?attr/dividerVertical" />

            <FrameLayout

            <FrameLayout

                android:id="@android:id/tabcontent"

                android:id="@android:id/tabcontent"

                android:layout_width="match_parent"

                android:layout_width="match_parent"
@@ -102,10 +109,7 @@ 
                    android:id="@+id/profile_pager"

                    android:id="@+id/profile_pager"

                    android:layout_width="match_parent"

                    android:layout_width="match_parent"

                    android:layout_height="wrap_content"

                    android:layout_height="wrap_content"

                    android:divider="?attr/dividerVertical"

                    android:minHeight="@dimen/resolver_empty_state_height" />

                    android:footerDividersEnabled="false"

                    android:headerDividersEnabled="false"

                    android:dividerHeight="1dp"/>

            </FrameLayout>

            </FrameLayout>

        </LinearLayout>

        </LinearLayout>

    </TabHost>

    </TabHost>

core/res/res/layout/resolver_list_per_profile.xml

+0 −1
Original line number Original line Diff line number Diff line
@@ -29,7 +29,6 @@ 
        android:elevation="@dimen/resolver_elevation"

        android:elevation="@dimen/resolver_elevation"

        android:nestedScrollingEnabled="true"

        android:nestedScrollingEnabled="true"

        android:scrollbarStyle="outsideOverlay"

        android:scrollbarStyle="outsideOverlay"

        android:scrollIndicators="top|bottom"

        android:divider="@null"

        android:divider="@null"

        android:footerDividersEnabled="false"

        android:footerDividersEnabled="false"

        android:headerDividersEnabled="false"

        android:headerDividersEnabled="false"