Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 92aed32d authored by Ryan Mitchell's avatar Ryan Mitchell Committed by android-build-team Robot
Browse files

ResStringPool: Prevenet boot loop from se fix 

Changes the logs adding in a previous security fix to warnings so
devices with malformed APKs currently on them will not undergo DOS when
they are upgraded to P.

Bug: 79724567
Test: run cts -m CtsAppSecurityHostTestCases \
          -t android.appsecurity.cts.CorruptApkTests

Change-Id: Ied54e4bb14abdaf79da562022c7ea6075187c1f8
(cherry picked from commit f05f47b2)
(cherry picked from commit c31cf800)
parent d0c09ae7

libs/androidfw/ResourceTypes.cpp

+2 −2
Original line number Diff line number Diff line
@@ -459,7 +459,7 @@ status_t ResStringPool::setTo(const void* data, size_t size, bool copyData) 


    // The chunk must be at least the size of the string pool header.

    if (size < sizeof(ResStringPool_header)) {

        LOG_ALWAYS_FATAL("Bad string block: data size %zu is too small to be a string block", size);

        ALOGW("Bad string block: data size %zu is too small to be a string block", size);

        return (mError=BAD_TYPE);

    }
@@ -469,7 +469,7 @@ status_t ResStringPool::setTo(const void* data, size_t size, bool copyData) 
    if (validate_chunk(reinterpret_cast<const ResChunk_header*>(data), sizeof(ResStringPool_header),

                       reinterpret_cast<const uint8_t*>(data) + size,

                       "ResStringPool_header") != NO_ERROR) {

        LOG_ALWAYS_FATAL("Bad string block: malformed block dimensions");

        ALOGW("Bad string block: malformed block dimensions");

        return (mError=BAD_TYPE);

    }