Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 91dbf7d0 authored by Himanshu Gupta's avatar Himanshu Gupta
Browse files

Restricitng ACTION_SESSION_COMMITTED broadcast for hidden profiles. 

ACTION_SESSION_COMMITTED is restricted if the target user is a
hidden profile and the target reciever (launcher) does not have
ACCESS_HIDDEN_PROFILES_FULL or ACCESS_HIDDEN_PROFILES
permissions granted.

Bug: 287975131
Test: atest PackageManagerTests
Flag: ACONFIG android.multiuser.enable_permission_to_access_hidden_profiles DEVELOPMENT
Change-Id: I6e4a0037957809844a4ae9c59dd40831020b905e
parent 2eeb4fb5

services/core/java/com/android/server/pm/BroadcastHelper.java

+33 −2
Original line number Diff line number Diff line
@@ -45,6 +45,8 @@ import android.content.Intent; 
import android.content.pm.PackageInstaller;

import android.content.pm.PackageManager;

import android.content.pm.UserInfo;

import android.content.pm.UserProperties;

import android.multiuser.Flags;

import android.net.Uri;

import android.os.Bundle;

import android.os.Handler;
@@ -361,14 +363,13 @@ public final class BroadcastHelper { 
        final UserInfo parent = ums.getProfileParent(userId);

        final int launcherUserId = (parent != null) ? parent.id : userId;

        final ComponentName launcherComponent = snapshot.getDefaultHomeActivity(launcherUserId);

        if (launcherComponent != null) {

        if (launcherComponent != null && canLauncherAccessProfile(launcherComponent, userId)) {

            Intent launcherIntent = new Intent(PackageInstaller.ACTION_SESSION_COMMITTED)

                    .putExtra(PackageInstaller.EXTRA_SESSION, sessionInfo)

                    .putExtra(Intent.EXTRA_USER, UserHandle.of(userId))

                    .setPackage(launcherComponent.getPackageName());

            mContext.sendBroadcastAsUser(launcherIntent, UserHandle.of(launcherUserId));

        }

        // TODO(b/122900055) Change/Remove this and replace with new permission role.

        if (appPredictionServicePackage != null) {

            Intent predictorIntent = new Intent(PackageInstaller.ACTION_SESSION_COMMITTED)

                    .putExtra(PackageInstaller.EXTRA_SESSION, sessionInfo)
@@ -378,6 +379,36 @@ public final class BroadcastHelper { 
        }

    }



    /**

     * A Profile is accessible to launcher in question if:

     * - It's not hidden for API visibility.

     * - Hidden, but launcher application has either

     *      {@link Manifest.permission.ACCESS_HIDDEN_PROFILES_FULL} or

     *      {@link Manifest.permission.ACCESS_HIDDEN_PROFILES}

     *   granted.

     */

    boolean canLauncherAccessProfile(ComponentName launcherComponent, int userId) {

        if (android.os.Flags.allowPrivateProfile()

                && Flags.enablePermissionToAccessHiddenProfiles()) {

            if (mUmInternal.getUserProperties(userId).getProfileApiVisibility()

                    != UserProperties.PROFILE_API_VISIBILITY_HIDDEN) {

                return true;

            }

            if (mContext.getPackageManager().checkPermission(

                            Manifest.permission.ACCESS_HIDDEN_PROFILES_FULL,

                            launcherComponent.getPackageName())

                    == PackageManager.PERMISSION_GRANTED) {

                return true;

            }

            // TODO(b/122900055) Change/Remove this and replace with new permission role.

            return mContext.getPackageManager().checkPermission(

                            Manifest.permission.ACCESS_HIDDEN_PROFILES,

                            launcherComponent.getPackageName())

                        == PackageManager.PERMISSION_GRANTED;

        }

        return true;

    }



    void sendPreferredActivityChangedBroadcast(int userId) {

        mHandler.post(() -> {

            final IActivityManager am = ActivityManager.getService();