Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9133f2f0 authored by Eric Biggers's avatar Eric Biggers
Browse files

Make setLockCredential() use doVerifyCredential()

Make setLockCredential() call the internal method doVerifyCredential()
instead of the public method verifyCredential().  This follows the best
practice for service implementations by not re-entering the Binder
interface as part of the implementation of a different method in the
interface.  Specifically, it avoids a redundant permission check that is
needed only for incoming Binder calls.  (setLockCredential() already
does its own permission check and clears the calling identity.)  It also
avoids a scheduleGc(), which again is done by setLockCredential().

No functional change other than removing redundant work.

Test: atest FrameworksServicesTests:com.android.server.locksettings
Bug: 320392352
Bug: 416768837
Flag: EXEMPT refactor
Change-Id: Iced66ee21db3c130f5606eb28d1f1b1d8385b836
parent 1a6bfba5
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment