Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9086588d authored by Caitlin Shkuratov's avatar Caitlin Shkuratov
Browse files

[Mobile] Show the roaming icon in the top-right on RTL. 

The old roaming drawable took up the full space of the signal icon, so
it couldn't be moved around using gravities alone. Reducing its size
to be just the size of the R lets us move it around correctly in RTL.

Fixes: 230795372
Test: `adb shell am broadcast -a com.android.systemui.demo -e command
network -e mobile show -e level 2 -e datatype roam -e slot 4 -e roam
show` -> see roaming icon in top-left of signal icon.
Test: above command in RTL -> see roaming icon in top-right of signal
icon.

Change-Id: Ie8be70a3c92e88bcfe0a9bdd9610995ccbfd9529
parent e6d80348

packages/SettingsLib/res/values/dimens.xml

+2 −0
Original line number Diff line number Diff line
@@ -67,6 +67,8 @@ 


    <!-- SignalDrawable -->

    <dimen name="signal_icon_size">15dp</dimen>

    <!-- The size of the roaming icon in the top-left corner of the signal icon. -->

    <dimen name="signal_icon_size_roaming">8dp</dimen>



    <!-- Size of nearby icon -->

    <dimen name="bt_nearby_icon_size">24dp</dimen>

packages/SystemUI/res-keyguard/layout/status_bar_mobile_signal_group_inner.xml

+1 −0
Original line number Diff line number Diff line
@@ -78,6 +78,7 @@ 
                android:id="@+id/mobile_roaming"

                android:layout_width="wrap_content"

                android:layout_height="wrap_content"

                android:layout_gravity="top|start"

                android:src="@drawable/stat_sys_roaming"

                android:contentDescription="@string/data_connection_roaming"

                android:visibility="gone" />

packages/SystemUI/res/drawable/stat_sys_roaming.xml

+4 −4
Original line number Diff line number Diff line
@@ -14,10 +14,10 @@ 
     limitations under the License.

-->

<vector xmlns:android="http://schemas.android.com/apk/res/android"

        android:width="@dimen/signal_icon_size"

        android:height="@dimen/signal_icon_size"

        android:viewportWidth="17"

        android:viewportHeight="17">

        android:width="@dimen/signal_icon_size_roaming"

        android:height="@dimen/signal_icon_size_roaming"

        android:viewportWidth="8"

        android:viewportHeight="8">



<path

    android:fillColor="#FFFFFFFF"