Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8f73644a authored by Jooyung Han's avatar Jooyung Han
Browse files

Remove unused methods in ApexManager.java 

checkApexSignature and getSigningDetails methods are no longer used, cleaning them up.

Bug: N/A
Flag: EXEMPT removing unused code
Test: Verified build and boot of the target.
Change-Id: Ia603f1af3fa6c9bf19dd435d058b2884e0aa7a7f
parent 220d8441

services/core/java/com/android/server/pm/ApexManager.java

+0 −26
Original line number Diff line number Diff line
@@ -886,32 +886,6 @@ public abstract class ApexManager { 
            waitForApexService().reserveSpaceForCompressedApex(infoList);

        }



        private SigningDetails getSigningDetails(PackageInfo pkg) throws PackageManagerException {

            final int minSignatureScheme =

                    ApkSignatureVerifier.getMinimumSignatureSchemeVersionForTargetSdk(

                            pkg.applicationInfo.targetSdkVersion);

            final ParseTypeImpl input = ParseTypeImpl.forDefaultParsing();

            final ParseResult<SigningDetails> result = ApkSignatureVerifier.verify(

                    input, pkg.applicationInfo.sourceDir, minSignatureScheme);

            if (result.isError()) {

                throw new PackageManagerException(result.getErrorCode(), result.getErrorMessage(),

                        result.getException());

            }

            return result.getResult();

        }



        private void checkApexSignature(PackageInfo existingApexPkg, PackageInfo newApexPkg)

                throws PackageManagerException {

            final SigningDetails existingSigningDetails = getSigningDetails(existingApexPkg);

            final SigningDetails newSigningDetails = getSigningDetails(newApexPkg);

            if (!newSigningDetails.checkCapability(existingSigningDetails,

                      SigningDetails.CertCapabilities.INSTALLED_DATA)) {

                throw new PackageManagerException(PackageManager.INSTALL_FAILED_BAD_SIGNATURE,

                          "APK container signature of " + newApexPkg.applicationInfo.sourceDir

                                   + " is not compatible with currently installed on device");

            }

        }



        @Override

        ApexInfo installPackage(File apexFile, boolean force)

                throws PackageManagerException {