Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ecc90d0 authored by Kobi Cohen Arazi's avatar Kobi Cohen Arazi
Browse files

Add lock before calling initEglImage 

Without that lock, there is a chance of race condition
where while composing a specific index, requestBuf with
the same index can be executed and touch the
same data that is being used in initEglImage.
(e.g. dirty flag in texture)
parent 08d9d9a4

services/surfaceflinger/Layer.cpp

+10 −2
Original line number Diff line number Diff line
@@ -874,8 +874,16 @@ status_t Layer::BufferManager::initEglImage(EGLDisplay dpy, 
    ssize_t index = mActiveBuffer;

    if (index >= 0) {

        if (!mFailover) {

            {

               // Without that lock, there is a chance of race condition

               // where while composing a specific index, requestBuf

               // with the same index can be executed and touch the same data

               // that is being used in initEglImage.

               // (e.g. dirty flag in texture)

               Mutex::Autolock _l(mLock);

               Image& texture(mBufferData[index].texture);

               err = mTextureManager.initEglImage(&texture, dpy, buffer);

            }

            // if EGLImage fails, we switch to regular texture mode, and we

            // free all resources associated with using EGLImages.

            if (err == NO_ERROR) {