Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e9b6f3f authored by Jeff DeCew's avatar Jeff DeCew
Browse files

Fix NPE in logActionClick when we were re-fetching the NotificationEntry we already had. 

Fixes: 189234737
Test: click a bunch of actions
Change-Id: I295eaadbef9f31b10e92f6d04d80cfe367a22af0
parent 6c9c6cb6

packages/SystemUI/src/com/android/systemui/statusbar/NotificationRemoteInputManager.java

+2 −4
Original line number Diff line number Diff line
@@ -221,12 +221,10 @@ public class NotificationRemoteInputManager implements Dumpable { 
                buttonIndex = actionGroup.indexOfChild(view);

            }

            final int count = mEntryManager.getActiveNotificationsCount();

            final int rank = mEntryManager

                    .getActiveNotificationUnfiltered(key).getRanking().getRank();

            final int rank = entry.getRanking().getRank();



            NotificationVisibility.NotificationLocation location =

                    NotificationLogger.getNotificationLocation(

                            mEntryManager.getActiveNotificationUnfiltered(key));

                    NotificationLogger.getNotificationLocation(entry);

            final NotificationVisibility nv =

                    NotificationVisibility.obtain(key, rank, count, true, location);

            mClickNotifier.onNotificationActionClick(key, buttonIndex, action, nv, false);