Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e5db408 authored by Qasid Ahmad Sadiq's avatar Qasid Ahmad Sadiq
Browse files

ItemViews accessibility enabled state should also reflect view.isEnabled. 

Now it takes into account, the listView.enabled, layoutParams.enabled and the view.enabled.
This bug resulted in some disabled items to not be presented as disabled to the accessibility service.
Fix: 138560025
Test: CTS ABSListViewTest, ListViewTest, DocumentsUIGoogleTests:RenameDocumentUiTest.

Change-Id: I0493545fbfc46ec80631caf78b8851bddc498775
parent c7ccc2cd

core/java/android/widget/AbsListView.java

+2 −4
Original line number Diff line number Diff line
@@ -2550,12 +2550,10 @@ public abstract class AbsListView extends AdapterView<ListAdapter> implements Te 
            return;

        }



        final boolean isItemEnabled;

        boolean isItemEnabled = view.isEnabled() && isEnabled();

        final ViewGroup.LayoutParams lp = view.getLayoutParams();

        if (lp instanceof AbsListView.LayoutParams) {

            isItemEnabled = ((AbsListView.LayoutParams) lp).isEnabled && isEnabled();

        } else {

            isItemEnabled = false;

            isItemEnabled &= ((AbsListView.LayoutParams) lp).isEnabled;

        }



        info.setEnabled(isItemEnabled);