Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e1cb133 authored by Matt Pietal's avatar Matt Pietal
Browse files

Revert "Remove dozeui binder call"

This reverts commit 61b2f3f6.

Reason for revert: b/332829814

Change-Id: If15324e78cfdd6c791eabf7dc42edd137b42b871
parent fc05d49c
Loading
Loading
Loading
Loading
+0 −4
Original line number Original line Diff line number Diff line
@@ -32,7 +32,6 @@ import androidx.core.content.res.ResourcesCompat
import com.android.compose.animation.scene.ElementKey
import com.android.compose.animation.scene.ElementKey
import com.android.compose.animation.scene.SceneScope
import com.android.compose.animation.scene.SceneScope
import com.android.systemui.animation.view.LaunchableImageView
import com.android.systemui.animation.view.LaunchableImageView
import com.android.systemui.dagger.qualifiers.Main
import com.android.systemui.keyguard.ui.binder.KeyguardIndicationAreaBinder
import com.android.systemui.keyguard.ui.binder.KeyguardIndicationAreaBinder
import com.android.systemui.keyguard.ui.binder.KeyguardQuickAffordanceViewBinder
import com.android.systemui.keyguard.ui.binder.KeyguardQuickAffordanceViewBinder
import com.android.systemui.keyguard.ui.view.KeyguardIndicationArea
import com.android.systemui.keyguard.ui.view.KeyguardIndicationArea
@@ -44,7 +43,6 @@ import com.android.systemui.res.R
import com.android.systemui.statusbar.KeyguardIndicationController
import com.android.systemui.statusbar.KeyguardIndicationController
import com.android.systemui.statusbar.VibratorHelper
import com.android.systemui.statusbar.VibratorHelper
import javax.inject.Inject
import javax.inject.Inject
import kotlinx.coroutines.CoroutineDispatcher
import kotlinx.coroutines.DisposableHandle
import kotlinx.coroutines.DisposableHandle
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.Flow


@@ -56,7 +54,6 @@ constructor(
    private val vibratorHelper: VibratorHelper,
    private val vibratorHelper: VibratorHelper,
    private val indicationController: KeyguardIndicationController,
    private val indicationController: KeyguardIndicationController,
    private val indicationAreaViewModel: KeyguardIndicationAreaViewModel,
    private val indicationAreaViewModel: KeyguardIndicationAreaViewModel,
    @Main private val mainImmediateDispatcher: CoroutineDispatcher,
) {
) {
    /**
    /**
     * Renders a single lockscreen shortcut.
     * Renders a single lockscreen shortcut.
@@ -164,7 +161,6 @@ constructor(
                        transitionAlpha,
                        transitionAlpha,
                        falsingManager,
                        falsingManager,
                        vibratorHelper,
                        vibratorHelper,
                        mainImmediateDispatcher,
                    ) {
                    ) {
                        indicationController.showTransientIndication(it)
                        indicationController.showTransientIndication(it)
                    }
                    }
+0 −4
Original line number Original line Diff line number Diff line
@@ -34,7 +34,6 @@ import com.android.keyguard.LockIconView
import com.android.keyguard.LockIconViewController
import com.android.keyguard.LockIconViewController
import com.android.systemui.biometrics.AuthController
import com.android.systemui.biometrics.AuthController
import com.android.systemui.dagger.qualifiers.Application
import com.android.systemui.dagger.qualifiers.Application
import com.android.systemui.dagger.qualifiers.Main
import com.android.systemui.deviceentry.shared.DeviceEntryUdfpsRefactor
import com.android.systemui.deviceentry.shared.DeviceEntryUdfpsRefactor
import com.android.systemui.flags.FeatureFlagsClassic
import com.android.systemui.flags.FeatureFlagsClassic
import com.android.systemui.flags.Flags
import com.android.systemui.flags.Flags
@@ -51,14 +50,12 @@ import com.android.systemui.shade.NotificationPanelView
import com.android.systemui.statusbar.VibratorHelper
import com.android.systemui.statusbar.VibratorHelper
import dagger.Lazy
import dagger.Lazy
import javax.inject.Inject
import javax.inject.Inject
import kotlinx.coroutines.CoroutineDispatcher
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.CoroutineScope


class LockSection
class LockSection
@Inject
@Inject
constructor(
constructor(
    @Application private val applicationScope: CoroutineScope,
    @Application private val applicationScope: CoroutineScope,
    @Main private val mainImmediateDispatcher: CoroutineDispatcher,
    private val windowManager: WindowManager,
    private val windowManager: WindowManager,
    private val authController: AuthController,
    private val authController: AuthController,
    private val featureFlags: FeatureFlagsClassic,
    private val featureFlags: FeatureFlagsClassic,
@@ -96,7 +93,6 @@ constructor(
                                deviceEntryBackgroundViewModel.get(),
                                deviceEntryBackgroundViewModel.get(),
                                falsingManager.get(),
                                falsingManager.get(),
                                vibratorHelper.get(),
                                vibratorHelper.get(),
                                mainImmediateDispatcher,
                            )
                            )
                        }
                        }
                    } else {
                    } else {
+2 −4
Original line number Original line Diff line number Diff line
@@ -214,16 +214,14 @@ class KeyguardInteractorTest : SysuiTestCase() {
            )
            )


            repository.setStatusBarState(StatusBarState.KEYGUARD)
            repository.setStatusBarState(StatusBarState.KEYGUARD)
            // User begins to swipe up
            shadeRepository.setLegacyShadeExpansion(1f)
            shadeRepository.setLegacyShadeExpansion(0.99f)


            // When not dismissable, no alpha value (null) should emit
            // When not dismissable, no alpha value (null) should emit
            repository.setKeyguardDismissible(false)
            repository.setKeyguardDismissible(false)
            assertThat(dismissAlpha).isNull()
            assertThat(dismissAlpha).isNull()


            repository.setKeyguardDismissible(true)
            repository.setKeyguardDismissible(true)
            shadeRepository.setLegacyShadeExpansion(0.98f)
            assertThat(dismissAlpha).isGreaterThan(0.95f)
            assertThat(dismissAlpha).isGreaterThan(0.5f)
        }
        }


    @Test
    @Test
+8 −12
Original line number Original line Diff line number Diff line
@@ -31,7 +31,6 @@ import android.view.ViewTreeObserver.OnGlobalLayoutListener
import androidx.annotation.VisibleForTesting
import androidx.annotation.VisibleForTesting
import androidx.lifecycle.Lifecycle
import androidx.lifecycle.Lifecycle
import androidx.lifecycle.repeatOnLifecycle
import androidx.lifecycle.repeatOnLifecycle
import com.android.app.tracing.coroutines.launch
import com.android.systemui.broadcast.BroadcastDispatcher
import com.android.systemui.broadcast.BroadcastDispatcher
import com.android.systemui.customization.R
import com.android.systemui.customization.R
import com.android.systemui.dagger.qualifiers.Background
import com.android.systemui.dagger.qualifiers.Background
@@ -66,7 +65,6 @@ import java.util.Locale
import java.util.TimeZone
import java.util.TimeZone
import java.util.concurrent.Executor
import java.util.concurrent.Executor
import javax.inject.Inject
import javax.inject.Inject
import kotlinx.coroutines.CoroutineDispatcher
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.DisposableHandle
import kotlinx.coroutines.DisposableHandle
import kotlinx.coroutines.Job
import kotlinx.coroutines.Job
@@ -74,6 +72,7 @@ import kotlinx.coroutines.flow.combine
import kotlinx.coroutines.flow.filter
import kotlinx.coroutines.flow.filter
import kotlinx.coroutines.flow.map
import kotlinx.coroutines.flow.map
import kotlinx.coroutines.flow.merge
import kotlinx.coroutines.flow.merge
import kotlinx.coroutines.launch


/**
/**
 * Controller for a Clock provided by the registry and used on the keyguard. Instantiated by
 * Controller for a Clock provided by the registry and used on the keyguard. Instantiated by
@@ -91,7 +90,6 @@ constructor(
    @DisplaySpecific private val resources: Resources,
    @DisplaySpecific private val resources: Resources,
    private val context: Context,
    private val context: Context,
    @Main private val mainExecutor: DelayableExecutor,
    @Main private val mainExecutor: DelayableExecutor,
    @Main private val mainImmediateDispatcher: CoroutineDispatcher,
    @Background private val bgExecutor: Executor,
    @Background private val bgExecutor: Executor,
    private val clockBuffers: ClockMessageBuffers,
    private val clockBuffers: ClockMessageBuffers,
    private val featureFlags: FeatureFlagsClassic,
    private val featureFlags: FeatureFlagsClassic,
@@ -426,7 +424,7 @@ constructor(
        keyguardUpdateMonitor.registerCallback(keyguardUpdateMonitorCallback)
        keyguardUpdateMonitor.registerCallback(keyguardUpdateMonitorCallback)
        zenModeController.addCallback(zenModeCallback)
        zenModeController.addCallback(zenModeCallback)
        disposableHandle =
        disposableHandle =
            parent.repeatWhenAttached(mainImmediateDispatcher) {
            parent.repeatWhenAttached {
                repeatOnLifecycle(Lifecycle.State.CREATED) {
                repeatOnLifecycle(Lifecycle.State.CREATED) {
                    listenForDozing(this)
                    listenForDozing(this)
                    if (MigrateClocksToBlueprint.isEnabled) {
                    if (MigrateClocksToBlueprint.isEnabled) {
@@ -531,14 +529,12 @@ constructor(


    @VisibleForTesting
    @VisibleForTesting
    internal fun listenForDozeAmount(scope: CoroutineScope): Job {
    internal fun listenForDozeAmount(scope: CoroutineScope): Job {
        return scope.launch("$TAG#listenForDozeAmount") {
        return scope.launch { keyguardInteractor.dozeAmount.collect { handleDoze(it) } }
            keyguardInteractor.dozeAmount.collect { handleDoze(it) }
        }
    }
    }


    @VisibleForTesting
    @VisibleForTesting
    internal fun listenForDozeAmountTransition(scope: CoroutineScope): Job {
    internal fun listenForDozeAmountTransition(scope: CoroutineScope): Job {
        return scope.launch("$TAG#listenForDozeAmountTransition") {
        return scope.launch {
            merge(
            merge(
                    keyguardTransitionInteractor.aodToLockscreenTransition.map { step ->
                    keyguardTransitionInteractor.aodToLockscreenTransition.map { step ->
                        step.copy(value = 1f - step.value)
                        step.copy(value = 1f - step.value)
@@ -556,7 +552,7 @@ constructor(
     */
     */
    @VisibleForTesting
    @VisibleForTesting
    internal fun listenForAnyStateToAodTransition(scope: CoroutineScope): Job {
    internal fun listenForAnyStateToAodTransition(scope: CoroutineScope): Job {
        return scope.launch("$TAG#listenForAnyStateToAodTransition") {
        return scope.launch {
            keyguardTransitionInteractor
            keyguardTransitionInteractor
                .transitionStepsToState(AOD)
                .transitionStepsToState(AOD)
                .filter { it.transitionState == TransitionState.STARTED }
                .filter { it.transitionState == TransitionState.STARTED }
@@ -567,7 +563,7 @@ constructor(


    @VisibleForTesting
    @VisibleForTesting
    internal fun listenForDozing(scope: CoroutineScope): Job {
    internal fun listenForDozing(scope: CoroutineScope): Job {
        return scope.launch("$TAG#listenForDozing") {
        return scope.launch {
            combine(
            combine(
                    keyguardInteractor.dozeAmount,
                    keyguardInteractor.dozeAmount,
                    keyguardInteractor.isDozing,
                    keyguardInteractor.isDozing,
@@ -632,7 +628,7 @@ constructor(
    }
    }


    companion object {
    companion object {
        private const val TAG = "ClockEventController"
        private val TAG = ClockEventController::class.simpleName!!
        private const val DOZE_TICKRATE_THRESHOLD = 0.99f
        private val DOZE_TICKRATE_THRESHOLD = 0.99f
    }
    }
}
}
+0 −9
Original line number Original line Diff line number Diff line
@@ -208,15 +208,6 @@ public class DozeLog implements Dumpable {
        mLogger.logTimeTickScheduled(when, triggerAt);
        mLogger.logTimeTickScheduled(when, triggerAt);
    }
    }


    /**
     * Logs cancelation requests for time ticks
     * @param isPending is an unschedule request pending?
     * @param isTimeTickScheduled is a time tick request scheduled
     */
    public void tracePendingUnscheduleTimeTick(boolean isPending, boolean isTimeTickScheduled) {
        mLogger.logPendingUnscheduleTimeTick(isPending, isTimeTickScheduled);
    }

    /**
    /**
     * Appends keyguard visibility change event to the logs
     * Appends keyguard visibility change event to the logs
     * @param showing whether the keyguard is now showing
     * @param showing whether the keyguard is now showing
Loading