Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d64dfc8 authored by James Mattis's avatar James Mattis
Browse files

Changing per-app default request to TRACK_DEFAULT 

Changing the per-app default request flows to fallback to a request of
type TRACK_DEFAULT as opposed to type REQUEST. The main benefit of this
change is that these requests will no longer be sent to the factories
which is desired.

Bug: 180452284
Bug: 176494815
Test: atest FrameworksNetTests
atest FrameworksNetIntegrationTests
atest CtsNetTestCasesLatestSdk

Change-Id: I312e55a54f70aa82953a32ab9369d5afc02b75e5
parent d703642a

services/core/java/com/android/server/ConnectivityService.java

+4 −2
Original line number Diff line number Diff line
@@ -9694,7 +9694,8 @@ public class ConnectivityService extends IConnectivityManager.Stub 
            // request.

            final ArrayList<NetworkRequest> nrs = new ArrayList<>();

            nrs.add(createNetworkRequest(NetworkRequest.Type.REQUEST, pref.capabilities));

            nrs.add(createDefaultRequest());

            nrs.add(createDefaultInternetRequestForTransport(

                    TYPE_NONE, NetworkRequest.Type.TRACK_DEFAULT));

            setNetworkRequestUids(nrs, UidRange.fromIntRanges(pref.capabilities.getUids()));

            final NetworkRequestInfo nri = new NetworkRequestInfo(Process.myUid(), nrs);

            result.add(nri);
@@ -9999,7 +10000,8 @@ public class ConnectivityService extends IConnectivityManager.Stub 
                case OemNetworkPreferences.OEM_NETWORK_PREFERENCE_OEM_PAID:

                    requests.add(createUnmeteredNetworkRequest());

                    requests.add(createOemPaidNetworkRequest());

                    requests.add(createDefaultRequest());

                    requests.add(createDefaultInternetRequestForTransport(

                            TYPE_NONE, NetworkRequest.Type.TRACK_DEFAULT));

                    break;

                case OemNetworkPreferences.OEM_NETWORK_PREFERENCE_OEM_PAID_NO_FALLBACK:

                    requests.add(createUnmeteredNetworkRequest());

tests/net/java/com/android/server/ConnectivityServiceTest.java

+1 −1
Original line number Diff line number Diff line
@@ -10479,7 +10479,7 @@ public class ConnectivityServiceTest { 
        assertTrue(mRequests.get(0).hasCapability(NET_CAPABILITY_VALIDATED));

        assertTrue(mRequests.get(1).isRequest());

        assertTrue(mRequests.get(1).hasCapability(NET_CAPABILITY_OEM_PAID));

        assertTrue(mRequests.get(2).isRequest());

        assertEquals(NetworkRequest.Type.TRACK_DEFAULT, mRequests.get(2).type);

        assertTrue(mService.getDefaultRequest().networkCapabilities.equalsNetCapabilities(

                mRequests.get(2).networkCapabilities));

    }