Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d1592e3 authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Inline InputMethodManagerService#updateSystemUi() 

This method is already called after locking with IMMS#mMethodMap.
Hence this method can be safely inlined.

This is a mechanical refactoring.  There should be no behavior change.

Bug: 34851776
Test: atest CtsInputMethodTestCases CtsInputMethodServiceHostTestCases
Change-Id: I50f8670b090183d29beebb3f26fd3238d93d41c5
parent 9b60ba07

services/core/java/com/android/server/inputmethod/InputMethodManagerService.java

+1 −7
Original line number Diff line number Diff line
@@ -2446,12 +2446,6 @@ public class InputMethodManagerService extends IInputMethodManager.Stub 
                (vis & InputMethodService.IME_VISIBLE) != 0, dismissImeOnBackKeyPressed);

    }



    private void updateSystemUi(IBinder token, int vis, int backDisposition) {

        synchronized (mMethodMap) {

            updateSystemUiLocked(token, vis, backDisposition);

        }

    }



    @BinderThread

    private void reportStartInput(IBinder token, IBinder startInputToken) {

        synchronized (mMethodMap) {
@@ -4049,7 +4043,7 @@ public class InputMethodManagerService extends IInputMethodManager.Stub 
            attrs.privateFlags |= PRIVATE_FLAG_SHOW_FOR_ALL_USERS;

            attrs.setTitle("Select input method");

            w.setAttributes(attrs);

            updateSystemUi(mCurToken, mImeWindowVis, mBackDisposition);

            updateSystemUiLocked(mCurToken, mImeWindowVis, mBackDisposition);

            mSwitchingDialog.show();

        }

    }