Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d0896c3 authored by Daniel Chapin's avatar Daniel Chapin Committed by Android (Google) Code Review
Browse files

Revert "camera2 jni: nativeReadValues() can use camera_metadata_ro_entry... 

Revert "camera2 jni: nativeReadValues() can use camera_metadata_ro_entry instead of camera_metadata_entry"

This reverts commit 3d5cfaac.

Reason for revert: DF Blocking bug: b/373532818

Change-Id: Ie1a401779eb2c1ebc01c55d5b044bc58e62b4517
parent 3d5cfaac

core/jni/android_hardware_camera2_CameraMetadata.cpp

+10 −8
Original line number Original line Diff line number Diff line
@@ -336,7 +336,7 @@ static void CameraMetadata_swap(JNIEnv *env, jclass thiz, jlong ptr, jlong other 
static jbyteArray CameraMetadata_readValues(JNIEnv *env, jclass thiz, jint tag, jlong ptr) {

static jbyteArray CameraMetadata_readValues(JNIEnv *env, jclass thiz, jint tag, jlong ptr) {

    ALOGV("%s (tag = %d)", __FUNCTION__, tag);

    ALOGV("%s (tag = %d)", __FUNCTION__, tag);





    const CameraMetadata *metadata = CameraMetadata_getPointerThrow(env, ptr);

    CameraMetadata* metadata = CameraMetadata_getPointerThrow(env, ptr);

    if (metadata == NULL) return NULL;

    if (metadata == NULL) return NULL;





    const camera_metadata_t *metaBuffer = metadata->getAndLock();

    const camera_metadata_t *metaBuffer = metadata->getAndLock();
@@ -349,14 +349,16 @@ static jbyteArray CameraMetadata_readValues(JNIEnv *env, jclass thiz, jint tag, 
    }

    }

    size_t tagSize = Helpers::getTypeSize(tagType);

    size_t tagSize = Helpers::getTypeSize(tagType);





    camera_metadata_ro_entry entry = metadata->find(tag);

    camera_metadata_entry entry = metadata->find(tag);

    if (entry.count == 0) {

    if (entry.count == 0) {

         if (!metadata->exists(tag)) {

         if (!metadata->exists(tag)) {

             ALOGV("%s: Tag %d does not have any entries", __FUNCTION__, tag);

             ALOGV("%s: Tag %d does not have any entries", __FUNCTION__, tag);

             return NULL;

         } else {

         } else {

            ALOGV("%s: Tag %d had an entry, but it had 0 data", __FUNCTION__, tag);

             // OK: we will return a 0-sized array.

             ALOGV("%s: Tag %d had an entry, but it had 0 data", __FUNCTION__,

                   tag);

         }

         }

        return NULL;

    }

    }





    jsize byteCount = entry.count * tagSize;

    jsize byteCount = entry.count * tagSize;