Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8cf4996f authored by Beverly's avatar Beverly Committed by Beverly Tai
Browse files

Set a good example - don't export ExamplePlugin 

Plugins should never be exported because this would allow other
packages installed on the device to attempt to launch it via
Context#startService which can crash SystemUI.

By default, if a service has an intent-filter, exported is set to true.
Therefore, we must explicitly set exported=false.

Test: n/a
Bug: 142012333
Change-Id: Iaf4191ee3006cc07eb0309f068854c103683e99d
parent aa88bb6b

packages/SystemUI/plugin/ExamplePlugin/AndroidManifest.xml

+4 −2
Original line number Diff line number Diff line
@@ -22,14 +22,16 @@ 


    <application>

        <activity android:name=".PluginSettings"

            android:label="@string/plugin_label">

                  android:label="@string/plugin_label"

                  android:exported="false">

            <intent-filter>

                <action android:name="com.android.systemui.action.PLUGIN_SETTINGS" />

            </intent-filter>

        </activity>



        <service android:name=".SampleOverlayPlugin"

            android:label="@string/plugin_label">

                 android:label="@string/plugin_label"

                 android:exported="false">

            <intent-filter>

                <action android:name="com.android.systemui.action.PLUGIN_OVERLAY" />

            </intent-filter>