Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c153628 authored by Steven Moreland's avatar Steven Moreland
Browse files

Parcel: markForBinder -> obtain(IBinder) 

So that the API more closely matches intended usage, as requested.

Bug: 175814583
Test: aidl_integration_test
Change-Id: I2fb5f2d5059d7f9cd9e034a4d0d2e7aa63692067
parent d801feda

core/java/android/os/Parcel.java

+18 −8
Original line number Diff line number Diff line
@@ -447,6 +447,23 @@ public final class Parcel { 
        return new Parcel(0);

    }



    /**

     * Retrieve a new Parcel object from the pool for use with a specific binder.

     *

     * Associate this parcel with a binder object. This marks the parcel as being prepared for a

     * transaction on this specific binder object. Based on this, the format of the wire binder

     * protocol may change. For future compatibility, it is recommended to use this for all

     * Parcels.

     *

     * @hide

     */

    @NonNull

    public static Parcel obtain(@NonNull IBinder binder) {

        Parcel parcel = Parcel.obtain();

        parcel.markForBinder(binder);

        return parcel;

    }



    /**

     * Put a Parcel object back into the pool.  You must not touch

     * the object after this call.
@@ -519,16 +536,9 @@ public final class Parcel { 
    }



    /**

     * Associate this parcel with a binder object. This marks the parcel as being prepared for a

     * transaction on this specific binder object. Based on this, the format of the wire binder

     * protocol may change. This should be called before any data is written to the parcel. If this

     * is called multiple times, this will only be marked for the last binder. For future

     * compatibility, it is recommended to call this on all parcels which are being sent over

     * binder.

     *

     * @hide

     */

    public void markForBinder(@NonNull IBinder binder) {

    private void markForBinder(@NonNull IBinder binder) {

        nativeMarkForBinder(mNativePtr, binder);

    }