Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c0a2a1a authored by Julia Tuttle's avatar Julia Tuttle
Browse files

VisualInterruptionDecisionProviderTestBase: test app suspended 

If an app is suspended in focus mode, we should suppress peek and pulse;
otherwise, the notifications may *immediately* peek or pulse when focus
mode ends.

Add tests that we suppress peek and pulse while an app is suspended.

These will fail, but the other two changes in this topic will implement
the change and make the tests pass.

Note that, despite touching code in the visual interruptions refactor,
this change is *not* related to or flagged by the refactor's feature
flag; this is a long-standing omission in our interruption logic, not a
bug in the refactored code.

Bug: 329620290
Flag: NA
Test: atest NotificationInterruptStateProviderWrapperTest
Test: atest VisualInterruptionDecisionProviderImplTest
Change-Id: Ia94dbde4f112595a4ec5a30800b9f5a2e6437fcc
parent 080c24aa

packages/SystemUI/tests/src/com/android/systemui/statusbar/notification/interruption/VisualInterruptionDecisionProviderTestBase.kt

+20 −6
Original line number Diff line number Diff line
@@ -326,6 +326,13 @@ abstract class VisualInterruptionDecisionProviderTestBase : SysuiTestCase() { 
        assertNoEventsLogged()

    }



    @Test

    fun testShouldNotPeek_appSuspended() {

        ensurePeekState()

        assertShouldNotBubble(buildPeekEntry { packageSuspended = true })

        assertNoEventsLogged()

    }



    @Test

    fun testShouldNotPeek_hiddenOnKeyguard() {

        ensurePeekState({ keyguardShouldHideNotification = true })
@@ -411,6 +418,13 @@ abstract class VisualInterruptionDecisionProviderTestBase : SysuiTestCase() { 
        assertNoEventsLogged()

    }



    @Test

    fun testShouldNotPulse_appSuspended() {

        ensurePulseState()

        assertShouldNotHeadsUp(buildPulseEntry { packageSuspended = true })

        assertNoEventsLogged()

    }



    @Test

    fun testShouldNotPulse_hiddenOnKeyguard() {

        ensurePulseState({ keyguardShouldHideNotification = true })
@@ -595,16 +609,16 @@ abstract class VisualInterruptionDecisionProviderTestBase : SysuiTestCase() { 
    }



    @Test

    fun testShouldNotBubble_hiddenOnKeyguard() {

        ensureBubbleState({ keyguardShouldHideNotification = true })

        assertShouldNotBubble(buildBubbleEntry())

    fun testShouldNotBubble_appSuspended() {

        ensureBubbleState()

        assertShouldNotBubble(buildBubbleEntry { packageSuspended = true })

        assertNoEventsLogged()

    }



    @Test

    fun testShouldNotBubble_bubbleAppSuspended() {

        ensureBubbleState()

        assertShouldNotBubble(buildBubbleEntry { packageSuspended = true })

    fun testShouldNotBubble_hiddenOnKeyguard() {

        ensureBubbleState({ keyguardShouldHideNotification = true })

        assertShouldNotBubble(buildBubbleEntry())

        assertNoEventsLogged()

    }