Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8b67be84 authored by Caitlin Cassidy's avatar Caitlin Cassidy
Browse files

[Status Bar Refactor] In CollapsedStatusBarFragment, use 

NotificationPanelViewController instead of StatusBar.java.

This was the last call into StatusBar.java, so marking the bug as fixed.
:D

Fixes: 204792508
Test: atest SystemUITests
Test: manual
Change-Id: I021d5d1bb211cf8a8cadad0a202a05566c78ce46
parent 1e172788

packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBar.java

+0 −4
Original line number Diff line number Diff line
@@ -1868,10 +1868,6 @@ public class StatusBar extends CoreStartable implements 
        return mDozeServiceHost.isPulsing();

    }



    public boolean hideStatusBarIconsWhenExpanded() {

        return mNotificationPanelViewController.hideStatusBarIconsWhenExpanded();

    }



    @Nullable

    public View getAmbientIndicationContainer() {

        return mAmbientIndicationContainer;

packages/SystemUI/src/com/android/systemui/statusbar/phone/dagger/StatusBarViewModule.java

+0 −6
Original line number Diff line number Diff line
@@ -46,7 +46,6 @@ import com.android.systemui.statusbar.phone.NotificationPanelView; 
import com.android.systemui.statusbar.phone.NotificationPanelViewController;

import com.android.systemui.statusbar.phone.NotificationShadeWindowView;

import com.android.systemui.statusbar.phone.NotificationsQuickSettingsContainer;

import com.android.systemui.statusbar.phone.StatusBar;

import com.android.systemui.statusbar.phone.StatusBarHideIconsForBouncerManager;

import com.android.systemui.statusbar.phone.StatusBarIconController;

import com.android.systemui.statusbar.phone.StatusBarLocationPublisher;
@@ -61,11 +60,8 @@ import com.android.systemui.statusbar.policy.ConfigurationController; 
import com.android.systemui.statusbar.policy.KeyguardStateController;

import com.android.systemui.tuner.TunerService;



import java.util.Optional;



import javax.inject.Named;



import dagger.Lazy;

import dagger.Module;

import dagger.Provides;
@@ -243,7 +239,6 @@ public abstract class StatusBarViewModule { 
            NotificationPanelViewController notificationPanelViewController,

            NetworkController networkController,

            StatusBarStateController statusBarStateController,

            Lazy<Optional<StatusBar>> statusBarOptionalLazy,

            CommandQueue commandQueue,

            CollapsedStatusBarFragmentLogger collapsedStatusBarFragmentLogger,

            OperatorNameViewController.Factory operatorNameViewControllerFactory
@@ -261,7 +256,6 @@ public abstract class StatusBarViewModule { 
                notificationPanelViewController,

                networkController,

                statusBarStateController,

                statusBarOptionalLazy,

                commandQueue,

                collapsedStatusBarFragmentLogger,

                operatorNameViewControllerFactory);

packages/SystemUI/src/com/android/systemui/statusbar/phone/fragment/CollapsedStatusBarFragment.java

+1 −10
Original line number Diff line number Diff line
@@ -55,7 +55,6 @@ import com.android.systemui.statusbar.events.SystemStatusAnimationScheduler; 
import com.android.systemui.statusbar.phone.NotificationIconAreaController;

import com.android.systemui.statusbar.phone.NotificationPanelViewController;

import com.android.systemui.statusbar.phone.PhoneStatusBarView;

import com.android.systemui.statusbar.phone.StatusBar;

import com.android.systemui.statusbar.phone.StatusBarHideIconsForBouncerManager;

import com.android.systemui.statusbar.phone.StatusBarIconController;

import com.android.systemui.statusbar.phone.StatusBarIconController.DarkIconManager;
@@ -71,12 +70,9 @@ import org.jetbrains.annotations.NotNull; 


import java.util.ArrayList;

import java.util.List;

import java.util.Optional;



import javax.inject.Inject;



import dagger.Lazy;



/**

 * Contains the collapsed status bar and handles hiding/showing based on disable flags

 * and keyguard state. Also manages lifecycle to make sure the views it contains are being
@@ -104,7 +100,6 @@ public class CollapsedStatusBarFragment extends Fragment implements CommandQueue 
    private View mCenteredIconArea;

    private int mDisabled1;

    private int mDisabled2;

    private Lazy<Optional<StatusBar>> mStatusBarOptionalLazy;

    private DarkIconManager mDarkIconManager;

    private final StatusBarFragmentComponent.Factory mStatusBarFragmentComponentFactory;

    private final CommandQueue mCommandQueue;
@@ -151,7 +146,6 @@ public class CollapsedStatusBarFragment extends Fragment implements CommandQueue 
            NotificationPanelViewController notificationPanelViewController,

            NetworkController networkController,

            StatusBarStateController statusBarStateController,

            Lazy<Optional<StatusBar>> statusBarOptionalLazy,

            CommandQueue commandQueue,

            CollapsedStatusBarFragmentLogger collapsedStatusBarFragmentLogger,

            OperatorNameViewController.Factory operatorNameViewControllerFactory
@@ -169,7 +163,6 @@ public class CollapsedStatusBarFragment extends Fragment implements CommandQueue 
        mNotificationPanelViewController = notificationPanelViewController;

        mNetworkController = networkController;

        mStatusBarStateController = statusBarStateController;

        mStatusBarOptionalLazy = statusBarOptionalLazy;

        mCommandQueue = commandQueue;

        mCollapsedStatusBarFragmentLogger = collapsedStatusBarFragmentLogger;

        mOperatorNameViewControllerFactory = operatorNameViewControllerFactory;
@@ -399,10 +392,8 @@ public class CollapsedStatusBarFragment extends Fragment implements CommandQueue 
    }



    private boolean shouldHideNotificationIcons() {

        final Optional<StatusBar> statusBarOptional = mStatusBarOptionalLazy.get();

        if (!mPanelExpansionStateManager.isClosed()

                && statusBarOptional.map(

                        StatusBar::hideStatusBarIconsWhenExpanded).orElse(false)) {

                && mNotificationPanelViewController.hideStatusBarIconsWhenExpanded()) {

            return true;

        }

        return mStatusBarHideIconsForBouncerManager.getShouldHideStatusBarIconsForBouncer();

packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/fragment/CollapsedStatusBarFragmentTest.java

+0 −5
Original line number Diff line number Diff line
@@ -50,7 +50,6 @@ import com.android.systemui.statusbar.events.SystemStatusAnimationScheduler; 
import com.android.systemui.statusbar.phone.HeadsUpAppearanceController;

import com.android.systemui.statusbar.phone.NotificationIconAreaController;

import com.android.systemui.statusbar.phone.NotificationPanelViewController;

import com.android.systemui.statusbar.phone.StatusBar;

import com.android.systemui.statusbar.phone.StatusBarHideIconsForBouncerManager;

import com.android.systemui.statusbar.phone.StatusBarIconController;

import com.android.systemui.statusbar.phone.StatusBarLocationPublisher;
@@ -68,8 +67,6 @@ import org.mockito.Mock; 
import org.mockito.Mockito;

import org.mockito.MockitoAnnotations;



import java.util.Optional;



@RunWith(AndroidTestingRunner.class)

@RunWithLooper(setAsMainLooper = true)

@SmallTest
@@ -85,7 +82,6 @@ public class CollapsedStatusBarFragmentTest extends SysuiBaseFragmentTest { 
    private NetworkController mNetworkController;

    private KeyguardStateController mKeyguardStateController;



    private final StatusBar mStatusBar = mock(StatusBar.class);

    private final CommandQueue mCommandQueue = mock(CommandQueue.class);

    private OperatorNameViewController.Factory mOperatorNameViewControllerFactory;

    private OperatorNameViewController mOperatorNameViewController;
@@ -335,7 +331,6 @@ public class CollapsedStatusBarFragmentTest extends SysuiBaseFragmentTest { 
                mNotificationPanelViewController,

                mNetworkController,

                mStatusBarStateController,

                () -> Optional.of(mStatusBar),

                mCommandQueue,

                new CollapsedStatusBarFragmentLogger(

                        new LogBuffer("TEST", 1, 1, mock(LogcatEchoTracker.class)),