Commit 8b62e317 authored May 14, 2019 by Kevin Committed by Kevin Han May 14, 2019

Fix legacy recents crash on Go devices

Go does not have PIP enabled and thus does not put the PipUI component
when starting up System UI service componenets. However, as part of
moving things to legacy recents, we are now always listening to PIP menu
events even with the feature disabled and we hit a NPE since we get a
null component. This CL adds a simple null check and backs out if we
don't have the component.

Bug: 132703125
Test: No longer crashes on KB3 Go device
Change-Id: I55e4fc30dc392a8052850a726e756b03fd4c91f6

parent dfae02f9

packages/SystemUI/legacy/recents/src/com/android/systemui/recents/LegacyRecentsImpl.java

+6 −0

Original line number	Diff line number	Diff line
		@@ -662,11 +662,17 @@ public class LegacyRecentsImpl implements RecentsImplementation {

		public final void onBusEvent(ExpandPipEvent event) {
		PipUI pipUi = getComponent(PipUI.class);
		if (pipUi == null) {
		return;
		}
		pipUi.expandPip();
		}

		public final void onBusEvent(HidePipMenuEvent event) {
		PipUI pipUi = getComponent(PipUI.class);
		if (pipUi == null) {
		return;
		}
		event.getAnimationTrigger().increment();
		pipUi.hidePipMenu(() -> {
		event.getAnimationTrigger().increment();