Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8b4d36e8 authored by Mike Lockwood's avatar Mike Lockwood
Browse files

USB: Fix NPE that occurred when restoring default function in UsbManager.setEnabledFunctions 



Bug: 5110020

Change-Id: I5e4b5c27e4675fa6830823832ae51411dc448191
Signed-off-by: default avatarMike Lockwood <lockwood@android.com>
parent ff7fffab

services/java/com/android/server/usb/UsbDeviceManager.java

+10 −6
Original line number Diff line number Diff line
@@ -388,13 +388,12 @@ public class UsbDeviceManager { 
        }



        private void setEnabledFunctions(String functions, boolean makeDefault) {

            if (functions != null && makeDefault) {

                if (mAdbEnabled) {

                    functions = addFunction(functions, UsbManager.USB_FUNCTION_ADB);

                } else {

                    functions = removeFunction(functions, UsbManager.USB_FUNCTION_ADB);

                }



            if (functions != null && makeDefault) {

                if (!mDefaultFunctions.equals(functions)) {

                    if (!setUsbConfig("none")) {

                        Slog.e(TAG, "Failed to disable USB");
@@ -418,6 +417,11 @@ public class UsbDeviceManager { 
                if (functions == null) {

                    functions = mDefaultFunctions;

                }

                if (mAdbEnabled) {

                    functions = addFunction(functions, UsbManager.USB_FUNCTION_ADB);

                } else {

                    functions = removeFunction(functions, UsbManager.USB_FUNCTION_ADB);

                }

                if (!mCurrentFunctions.equals(functions)) {

                    if (!setUsbConfig("none")) {

                        Slog.e(TAG, "Failed to disable USB");