Follow minikin::FontFamily constructor signature change.
This is 2nd attempt of Id10ca97f6f6f5bbe4999c1ad2736423a204d6e87. The root caus of crash is due touching null pointer in nUnrefFamily. After above change, native object may not be created on error case. In that case, nUnrefFamily can not be called. In addition to this issue there is also memory leak on error case. This fixes it by introducing abortCreation method. Also this contains fix of layout lib breakage done by jgaillard@. Originally submitted by Ic8872a43993bcb0a157c5e3f0ce423af9b47f606 Here is original commit message of reverted change. minikin::FontFamily no longer has addFont function, instead it accept vector of Fonts in its constructor. To follow this signature change, holding minikin::Font instance in native and build minikin::FontFamily instance in FontFamily.freeze() method. Bug: 34042446 Bug: 28119474 Bug: 34378805 Test: hwui test has passed Test: m layoutlib layoutlib-tests Change-Id: Ic34ebaa8191273d4c9f49c43124f15a1da5f7b78
Loading
Please register or sign in to comment