Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8a83fb37 authored by Harry Cutts's avatar Harry Cutts
Browse files

Sony DualShock 4: disable drumroll detection by speed change 

Bug: 272518665
Test: use the DS4 touchpad (over Bluetooth) for a few minutes, check
      pointer movements remain smooth
Change-Id: I07e613c6cf4ea7920b528c03695cf0089ad0bce2
parent 4e62d6c3

data/keyboards/Vendor_054c_Product_05c4.idc

+21 −1
Original line number Diff line number Diff line
@@ -13,9 +13,11 @@ 
# limitations under the License.



#

# Sony DS4 motion sensor configuration file.

# Sony Playstation(R) DualShock 4 Controller

#



## Motion sensor ##



# reporting mode 0 - continuous

sensor.accelerometer.reportingMode = 0

# The delay between sensor events corresponding to the lowest frequency in microsecond
@@ -33,3 +35,21 @@ sensor.gyroscope.maxDelay = 100000 
sensor.gyroscope.minDelay = 5000

# The power in mA used by this sensor while in use

sensor.gyroscope.power = 0.8



## Touchpad ##



# After the DualShock 4 has been connected over Bluetooth for a minute or so,

# its reports start bunching up in time, meaning that we receive 2–4 reports

# within a millisecond followed by a >10ms wait until the next batch.

#

# This uneven timing causes the apparent speed of a finger (calculated using

# time deltas between received reports) to vary dramatically even if it's

# actually moving smoothly across the touchpad, triggering the touchpad stack's

# drumroll detection logic, which causes the finger's single smooth movement to

# be treated as many small movements of consecutive touches, which are then

# inhibited by the click wiggle filter.

#

# Since this touchpad does not seem vulnerable to click wiggle, we can safely

# disable drumroll detection due to speed changes (by setting the speed change

# threshold very high, since there's no boolean control property).

gestureProp.Drumroll_Max_Speed_Change_Factor = 1000000000

data/keyboards/Vendor_054c_Product_09cc.idc

+21 −1
Original line number Diff line number Diff line
@@ -13,9 +13,11 @@ 
# limitations under the License.



#

# Sony DS4 motion sensor configuration file.

# Sony Playstation(R) DualShock 4 Controller

#



## Motion sensor ##



# reporting mode 0 - continuous

sensor.accelerometer.reportingMode = 0

# The delay between sensor events corresponding to the lowest frequency in microsecond
@@ -33,3 +35,21 @@ sensor.gyroscope.maxDelay = 100000 
sensor.gyroscope.minDelay = 5000

# The power in mA used by this sensor while in use

sensor.gyroscope.power = 0.8



## Touchpad ##



# After the DualShock 4 has been connected over Bluetooth for a minute or so,

# its reports start bunching up in time, meaning that we receive 2–4 reports

# within a millisecond followed by a >10ms wait until the next batch.

#

# This uneven timing causes the apparent speed of a finger (calculated using

# time deltas between received reports) to vary dramatically even if it's

# actually moving smoothly across the touchpad, triggering the touchpad stack's

# drumroll detection logic, which causes the finger's single smooth movement to

# be treated as many small movements of consecutive touches, which are then

# inhibited by the click wiggle filter.

#

# Since this touchpad does not seem vulnerable to click wiggle, we can safely

# disable drumroll detection due to speed changes (by setting the speed change

# threshold very high, since there's no boolean control property).

gestureProp.Drumroll_Max_Speed_Change_Factor = 1000000000