Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8a01b050 authored by Andrew Lee's avatar Andrew Lee Committed by Android (Google) Code Review
Browse files

Merge "Don't throw RemoteException in public RemoteCallVideoClient APIs." into lmp-dev

parents 7ea62ba9 8a57efb7
Loading
Loading
Loading
Loading
+7 −8
Original line number Diff line number Diff line
@@ -28706,14 +28706,13 @@ package android.telecomm {
    field public static final android.os.Parcelable.Creator CREATOR;
  }
  public class RemoteCallVideoClient implements android.os.IBinder.DeathRecipient {
    method public void binderDied();
    method public void handleCallSessionEvent(int) throws android.os.RemoteException;
    method public void handleCameraCapabilitiesChange(android.telecomm.CallCameraCapabilities) throws android.os.RemoteException;
    method public void receiveSessionModifyRequest(android.telecomm.VideoCallProfile) throws android.os.RemoteException;
    method public void receiveSessionModifyResponse(int, android.telecomm.VideoCallProfile, android.telecomm.VideoCallProfile) throws android.os.RemoteException;
    method public void updateCallDataUsage(int) throws android.os.RemoteException;
    method public void updatePeerDimensions(int, int) throws android.os.RemoteException;
  public class RemoteCallVideoClient {
    method public void handleCallSessionEvent(int);
    method public void handleCameraCapabilitiesChange(android.telecomm.CallCameraCapabilities);
    method public void receiveSessionModifyRequest(android.telecomm.VideoCallProfile);
    method public void receiveSessionModifyResponse(int, android.telecomm.VideoCallProfile, android.telecomm.VideoCallProfile);
    method public void updateCallDataUsage(int);
    method public void updatePeerDimensions(int, int);
  }
  public class RemoteCallVideoProvider {
+43 −23
Original line number Diff line number Diff line
@@ -26,18 +26,21 @@ import com.android.internal.telecomm.ICallVideoClient;
/**
 * Remote class to invoke callbacks in InCallUI related to supporting video in calls.
 */
public class RemoteCallVideoClient implements IBinder.DeathRecipient {
public class RemoteCallVideoClient {
    private final ICallVideoClient mCallVideoClient;

    RemoteCallVideoClient(ICallVideoClient callVideoProvider) throws RemoteException {
        mCallVideoClient = callVideoProvider;
        mCallVideoClient.asBinder().linkToDeath(this, 0);
    }

    private IBinder.DeathRecipient mDeathRecipient = new IBinder.DeathRecipient() {
        @Override
        public void binderDied() {
            mCallVideoClient.asBinder().unlinkToDeath(this, 0);
        }
    };

    /** {@hide} */
    RemoteCallVideoClient(ICallVideoClient callVideoProvider) throws RemoteException {
        mCallVideoClient = callVideoProvider;
        mCallVideoClient.asBinder().linkToDeath(mDeathRecipient, 0);
    }

    /**
     * Called when a session modification request is received from the remote device.
@@ -49,9 +52,11 @@ public class RemoteCallVideoClient implements IBinder.DeathRecipient {
     *
     * @param videoCallProfile The requested video call profile.
     */
    public void receiveSessionModifyRequest(VideoCallProfile videoCallProfile)
            throws RemoteException {
    public void receiveSessionModifyRequest(VideoCallProfile videoCallProfile) {
        try {
            mCallVideoClient.receiveSessionModifyRequest(videoCallProfile);
        } catch (RemoteException e) {
        }
    }

    /**
@@ -66,9 +71,13 @@ public class RemoteCallVideoClient implements IBinder.DeathRecipient {
     * @param requestedProfile The original request which was sent to the remote device.
     * @param responseProfile The actual profile changes made by the remote device.
     */
    public void receiveSessionModifyResponse(int status, VideoCallProfile requestedProfile,
            VideoCallProfile responseProfile) throws RemoteException {
        mCallVideoClient.receiveSessionModifyResponse(status, requestedProfile, responseProfile);
    public void receiveSessionModifyResponse(
            int status, VideoCallProfile requestedProfile, VideoCallProfile responseProfile) {
        try {
            mCallVideoClient.receiveSessionModifyResponse(
                    status, requestedProfile, responseProfile);
        } catch (RemoteException e) {
        }
    }

    /**
@@ -81,8 +90,11 @@ public class RemoteCallVideoClient implements IBinder.DeathRecipient {
     *
     * @param event The event.
     */
    public void handleCallSessionEvent(int event) throws RemoteException {
    public void handleCallSessionEvent(int event) {
        try {
            mCallVideoClient.handleCallSessionEvent(event);
        } catch (RemoteException e) {
        }
    }

    /**
@@ -92,8 +104,11 @@ public class RemoteCallVideoClient implements IBinder.DeathRecipient {
     * @param width  The updated peer video width.
     * @param height The updated peer video height.
     */
    public void updatePeerDimensions(int width, int height) throws RemoteException {
    public void updatePeerDimensions(int width, int height) {
        try {
            mCallVideoClient.updatePeerDimensions(width, height);
        } catch (RemoteException e) {
        }
    }

    /**
@@ -101,8 +116,11 @@ public class RemoteCallVideoClient implements IBinder.DeathRecipient {
     *
     * @param dataUsage The updated data usage.
     */
    public void updateCallDataUsage(int dataUsage) throws RemoteException {
    public void updateCallDataUsage(int dataUsage) {
        try {
            mCallVideoClient.updateCallDataUsage(dataUsage);
        } catch (RemoteException e) {
        }
    }

    /**
@@ -110,8 +128,10 @@ public class RemoteCallVideoClient implements IBinder.DeathRecipient {
     *
     * @param callCameraCapabilities The changed camera capabilities.
     */
    public void handleCameraCapabilitiesChange(CallCameraCapabilities callCameraCapabilities)
            throws RemoteException {
    public void handleCameraCapabilitiesChange(CallCameraCapabilities callCameraCapabilities) {
        try {
            mCallVideoClient.handleCameraCapabilitiesChange(callCameraCapabilities);
        } catch (RemoteException e) {
        }
    }
}
 No newline at end of file