Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 89eb9b45 authored by Hui Shu's avatar Hui Shu
Browse files

Deprecate setGeolocationDatabasePath because it is no-op since KitKat 

Also updated the documentation of setGeolocationEnabled.

BUG: crbug.com/507505
Change-Id: I5f4bb38189338f58dcd4c1ba0310493aeac5cbd2
parent fff12cd7

api/current.txt

+1 −1
Original line number Diff line number Diff line
@@ -44046,7 +44046,7 @@ package android.webkit { 
    method public abstract deprecated void setEnableSmoothTransition(boolean);

    method public abstract void setFantasyFontFamily(java.lang.String);

    method public abstract void setFixedFontFamily(java.lang.String);

    method public abstract void setGeolocationDatabasePath(java.lang.String);

    method public abstract deprecated void setGeolocationDatabasePath(java.lang.String);

    method public abstract void setGeolocationEnabled(boolean);

    method public abstract void setJavaScriptCanOpenWindowsAutomatically(boolean);

    method public abstract void setJavaScriptEnabled(boolean);

api/system-current.txt

+1 −1
Original line number Diff line number Diff line
@@ -46464,7 +46464,7 @@ package android.webkit { 
    method public abstract deprecated void setEnableSmoothTransition(boolean);

    method public abstract void setFantasyFontFamily(java.lang.String);

    method public abstract void setFixedFontFamily(java.lang.String);

    method public abstract void setGeolocationDatabasePath(java.lang.String);

    method public abstract deprecated void setGeolocationDatabasePath(java.lang.String);

    method public abstract void setGeolocationEnabled(boolean);

    method public abstract void setJavaScriptCanOpenWindowsAutomatically(boolean);

    method public abstract void setJavaScriptEnabled(boolean);

api/test-current.txt

+1 −1
Original line number Diff line number Diff line
@@ -44062,7 +44062,7 @@ package android.webkit { 
    method public abstract deprecated void setEnableSmoothTransition(boolean);

    method public abstract void setFantasyFontFamily(java.lang.String);

    method public abstract void setFixedFontFamily(java.lang.String);

    method public abstract void setGeolocationDatabasePath(java.lang.String);

    method public abstract deprecated void setGeolocationDatabasePath(java.lang.String);

    method public abstract void setGeolocationEnabled(boolean);

    method public abstract void setJavaScriptCanOpenWindowsAutomatically(boolean);

    method public abstract void setJavaScriptEnabled(boolean);

core/java/android/webkit/WebSettings.java

+3 −6
Original line number Diff line number Diff line
@@ -987,9 +987,6 @@ public abstract class WebSettings { 
     * @deprecated Database paths are managed by the implementation and calling this method

     *             will have no effect.

     */

    // This will update WebCore when the Sync runs in the C++ side.

    // Note that the WebCore Database Tracker only allows the path to be set

    // once.

    @Deprecated

    public abstract void setDatabasePath(String databasePath);
@@ -1000,8 +997,10 @@ public abstract class WebSettings { 
     *

     * @param databasePath a path to the directory where databases should be

     *                     saved.

     * @deprecated Geolocation database are managed by the implementation and calling this method

     *             will have no effect.

     */

    // This will update WebCore when the Sync runs in the C++ side.

    @Deprecated

    public abstract void setGeolocationDatabasePath(String databasePath);



    /**
@@ -1102,8 +1101,6 @@ public abstract class WebSettings { 
     *   via the JavaScript Geolocation API.

     * </ul>

     * <p>

     * As an option, it is possible to store previous locations and web origin

     * permissions in a database. See {@link #setGeolocationDatabasePath}.

     *

     * @param flag whether Geolocation should be enabled

     */