Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 898cffe6 authored by Caitlin Cassidy's avatar Caitlin Cassidy
Browse files

[Ongoing Call] Remove TODOs that are no longer relevant. 

- system_gestures_start_threshold shouldn't ever change size.
- statusBarHeight does seem like the appropriate dimension to use to
determine the appropriate gesture area.

Bug: 195839150
Test: N/A (just removing code comments)
Change-Id: I1076d83120df0e1ea51d4e8d568a7a270cf35911
parent 4a902724

packages/SystemUI/src/com/android/systemui/statusbar/gesture/SwipeStatusBarAwayGestureHandler.kt

+0 −3
Original line number Diff line number Diff line
@@ -53,7 +53,6 @@ open class SwipeStatusBarAwayGestureHandler @Inject constructor( 
    private var inputMonitor: InputMonitorCompat? = null

    private var inputReceiver: InputChannelCompat.InputEventReceiver? = null



    // TODO(b/195839150): Update this threshold when the config changes?

    private var swipeDistanceThreshold: Int = context.resources.getDimensionPixelSize(

        com.android.internal.R.dimen.system_gestures_start_threshold

    )
@@ -84,8 +83,6 @@ open class SwipeStatusBarAwayGestureHandler @Inject constructor( 
            ACTION_DOWN -> {

                if (

                    // Gesture starts just below the status bar

                    // TODO(b/195839150): Is [statusBarHeight] the correct dimension to use for

                    //   determining which down touches are valid?

                    ev.y >= statusBarWindowController.statusBarHeight

                    && ev.y <= 3 * statusBarWindowController.statusBarHeight

                ) {