Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8939838d authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

IME switcher should not always require IME_VISIBLE. 

When one ore more physical keyboards are attached, we should not require
InputMethodService.IME_VISIBLE to show the IME switcher because some
IMEs such as LatinIME shows no software keyboard w/ physical keyboard.

Bug: 26245853
Change-Id: I8aac9f5989ebaf544ace06a3ba0993b3a834869d
parent 75c21ca9

services/core/java/com/android/server/InputMethodManagerService.java

+2 −1
Original line number Diff line number Diff line
@@ -1715,8 +1715,9 @@ public class InputMethodManagerService extends IInputMethodManager.Stub 
            // exists in the IME switcher dialog.  Might be OK to remove this condition once

            // SHOW_IME_WITH_HARD_KEYBOARD settings finds a good place to live.

            return true;

        } else if ((visibility & InputMethodService.IME_VISIBLE) == 0) {

            return false;

        }

        if ((visibility & InputMethodService.IME_VISIBLE) == 0) return false;



        List<InputMethodInfo> imis = mSettings.getEnabledInputMethodListLocked();

        final int N = imis.size();